Refactor internal parameters api #4275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
api/parameter_module_refactor
branch
from
f2e6856 to
0cb07b0
Compare
Codecov Report
@@ Coverage Diff @@
## master #4275 +/- ##
==========================================
+ Coverage 68.35% 68.40% +0.04%
==========================================
Files 241 249 +8
Lines 30894 30941 +47
==========================================
+ Hits 21119 21166 +47
Misses 9775 9775 |
jenshnielsen
commented
Jun 16, 2022
jenshnielsen
commented
Jun 16, 2022
trevormorgan
approved these changes
Jun 17, 2022
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that parameters are in their own modules it makes sense to split this up into smaller modules.