Split instrument module in Parameters and Instrument modules #3972

jenshnielsen · 2022-03-01T12:43:58Z

Update tests and internal use for the new modules.
Readd old modules for backwards compatibility
Ensure that instrument module contains the right imports
Ensure that parameters module contains the right imports
Renamed _BaseParameter to ParameterBase

Things to do after this pr merges

Reorganize new parameter modules better
Enable autodocsumm for the new modules

codecov · 2022-03-01T12:55:34Z

Codecov Report

Merging #3972 (32236e0) into master (fa7e07c) will decrease coverage by 0.04%.
The diff coverage is 93.58%.

@@            Coverage Diff             @@
##           master    #3972      +/-   ##
==========================================
- Coverage   68.39%   68.35%   -0.05%     
==========================================
  Files         235      241       +6     
  Lines       30887    30887              
==========================================
- Hits        21125    21112      -13     
- Misses       9762     9775      +13

qcodes/instrument/__init__.py

qcodes/instrument/channel.py

qcodes/instrument_drivers/QDev/QDac_channels.py

qcodes/instrument_drivers/QDevil/QDevil_QDAC.py

qcodes/parameters/group_parameter.py

qcodes/parameters/parameter.py

Makes it consistent with InstrumentBase Avoid _ Private outside module

qcodes/dataset/data_set.py

jenshnielsen · 2022-06-16T05:50:29Z

bors merge

docs/examples/15_minutes_to_QCoDeS.ipynb

bors · 2022-06-16T05:52:01Z

Canceled.

jenshnielsen · 2022-06-16T06:43:26Z

bors merge

3972: Split instrument module in Parameters and Instrument modules r=jenshnielsen a=jenshnielsen - [X] Update tests and internal use for the new modules. - [x] Readd old modules for backwards compatibility - [x] Ensure that instrument module contains the right imports - [x] Ensure that parameters module contains the right imports - [x] Renamed _BaseParameter to ParameterBase Things to do after this pr merges - [ ] Reorganize new parameter modules better - [ ] Enable autodocsumm for the new modules Co-authored-by: Jens H. Nielsen <[email protected]> Co-authored-by: Jens Hedegaard Nielsen <[email protected]>

bors · 2022-06-16T06:44:35Z

Build failed:

pytestmin (ubuntu-latest, 3.7)

jenshnielsen · 2022-06-16T07:16:42Z

Bors retry

bors · 2022-06-16T07:46:47Z

Build succeeded:

jenshnielsen changed the title ~~declare functions and methods in qcodes.instrument as reexported~~ declare functions and methods in qcodes.instrument and qcodes.config as reexported Mar 1, 2022

Dominik-Vogel approved these changes Mar 1, 2022

View reviewed changes

jenshnielsen force-pushed the qcodes_instrument_public_interface branch from 7d96cb9 to 9102b37 Compare April 17, 2022 08:26

astafan8 added this to the 0.34.0 milestone Apr 26, 2022

astafan8 approved these changes Jun 3, 2022

View reviewed changes

astafan8 force-pushed the qcodes_instrument_public_interface branch from cacfda7 to 3f05dd9 Compare June 3, 2022 10:09

jenshnielsen force-pushed the qcodes_instrument_public_interface branch 3 times, most recently from 692be99 to bf4be03 Compare June 4, 2022 10:20

jenshnielsen changed the title ~~declare functions and methods in qcodes.instrument and qcodes.config as reexported~~ declare functions and methods in qcodes.instrument as reexported Jun 4, 2022

jenshnielsen force-pushed the qcodes_instrument_public_interface branch 8 times, most recently from 890a925 to 40e0a62 Compare June 13, 2022 11:32