Add cache reprecentation of dataset #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianhuezo
reviewed
Jun 26, 2020
hbarovertwo
reviewed
Jun 27, 2020
jenshnielsen
force-pushed
the
cache_loaded_data
branch
5 times, most recently
from
c10a249 to
6e5a120
Compare
jenshnielsen
force-pushed
the
cache_loaded_data
branch
from
6e5a120 to
688c0b6
Compare
Codecov Report
@@ Coverage Diff @@
## master #2062 +/- ##
==========================================
+ Coverage 71.13% 71.20% +0.07%
==========================================
Files 150 151 +1
Lines 20066 20147 +81
==========================================
+ Hits 14273 14346 +73
- Misses 5793 5801 +8 |
jenshnielsen
force-pushed
the
cache_loaded_data
branch
3 times, most recently
from
f8ebae1 to
edb2c5a
Compare
jenshnielsen
force-pushed
the
cache_loaded_data
branch
from
08c2205 to
0e72125
Compare
astafan8
reviewed
Aug 6, 2020
Co-authored-by: Mikhail Astafev <[email protected]>
Co-authored-by: Mikhail Astafev <[email protected]>
astafan8
approved these changes
Aug 12, 2020
| no load will be performed. | ||
| """ | ||
| if self._loaded_from_completed_ds: | ||
| return |
There was a problem hiding this comment.
wow, codecov tells that we don't have a test for this case :)
There was a problem hiding this comment.
Yes, rewrote the tests to ensure that we also trigger this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very much work in progress.