Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in parallel #2040

Merged
merged 38 commits into from
Jun 18, 2020
Merged

Conversation

GateBuilder
Copy link
Contributor

This PR introduces changes to run test suit in parallel with pytest-xdist.

@jenshnielsen

@GateBuilder
Copy link
Contributor Author

@jenshnielsen Nodes are crushing :(

@GateBuilder
Copy link
Contributor Author

Instead of auto I suggest to use 4 cores for starters.

@GateBuilder
Copy link
Contributor Author

GateBuilder commented Jun 10, 2020

Travis runs on 2 cores at auto mode :) (also pipelines)

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #2040 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2040      +/-   ##
==========================================
- Coverage   71.43%   71.43%   -0.01%     
==========================================
  Files         149      149              
  Lines       20065    20063       -2     
==========================================
- Hits        14333    14331       -2     
  Misses       5732     5732              

@jenshnielsen
Copy link
Collaborator

there are still references to math within field_vector.rst

@astafan8
Copy link
Contributor

was it really necessary to move the field_vector to math_utils?

@GateBuilder
Copy link
Contributor Author

@astafan8 We were getting ImportError: cannot import name 'log' from 'math' (/home/travis/build/QCoDeS/Qcodes/qcodes/math/__init__.py), which should be imported from elsewhere.

@jenshnielsen
Copy link
Collaborator

an alternative solution would probably be to avoid running the tests from within the qcodes source directory. Moving math is unfortunate as it is a breaking change but it seems like it should never have been called math in the first place

@jenshnielsen
Copy link
Collaborator

this seems to be the problem pytest-dev/pytest-xdist#421

@GateBuilder
Copy link
Contributor Author

@jenshnielsen let us merge this! nightmare. :)

@jenshnielsen
Copy link
Collaborator

Please write a note in the changelog that the math module has moved

@jenshnielsen
Copy link
Collaborator

There are some issues with the code coverage that we need to fix

@jenshnielsen
Copy link
Collaborator

@astafan8 Do you want to have a final look?

@jenshnielsen jenshnielsen merged commit 6ba7d9b into microsoft:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants