Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to check-spelling v0.0.24 #36235

Merged
merged 67 commits into from
Dec 6, 2024
Merged
Changes from 1 commit
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
44ae91f
link: Lcl files section
jsoref Nov 29, 2024
8839cb2
link: the host is network isolated
jsoref Nov 29, 2024
e6cfa79
link: onebranch (account required) under Localization
jsoref Nov 29, 2024
e56284d
link: building the installer on the pipeline
jsoref Nov 29, 2024
662f79c
link: Enabling localized MSI for a new project
jsoref Nov 29, 2024
bd7c6ed
link: convert-resx-to-rc.ps1
jsoref Nov 29, 2024
3627f23
link: lines 50-77 of `convert-resx-to-rc.ps1`
jsoref Nov 29, 2024
ac468a7
link: PowerToys issue #7269
jsoref Nov 29, 2024
21cf85d
link: Product.wxs near line 806
jsoref Nov 29, 2024
dfa2bd8
link: Product.wxs near lines 845-847
jsoref Nov 29, 2024
168de1b
link: shared hooks
jsoref Nov 29, 2024
5de5c6b
link: rationale of the current design
jsoref Nov 29, 2024
1891f2e
link: described in detail
jsoref Nov 29, 2024
457585a
link: described in more detail
jsoref Nov 29, 2024
bc74b76
link: AppSpecificShortcutRemappingTests.cpp
jsoref Nov 29, 2024
eb8677a
link: View Model as it used to communicate common data that is shared…
jsoref Nov 29, 2024
26c5335
link: last hook to be registered receives the input first
jsoref Nov 29, 2024
752a8a1
link: enable/disable code can be found in dllmain.cpp
jsoref Nov 29, 2024
57eb90c
link: keyboardmanagerui: OK and Cancel button
jsoref Nov 29, 2024
e2278ed
link: DetectSingleRemapKeyUIBackend and DetectShortcutUIBackend
jsoref Nov 29, 2024
5b90552
link: DetectSingleRemapKeyUIBackend and DetectShortcutUIBackend
jsoref Nov 29, 2024
9b9ae5a
link: HandleSingleKeyRemapEvent
jsoref Nov 29, 2024
f5dfeb8
link: HandleAppSpecificShortcutRemapEvent
jsoref Nov 29, 2024
89a32d2
link: HandleOSLevelShortcutRemapEvent
jsoref Nov 29, 2024
85186e4
link: Keyboard Manager UI
jsoref Nov 29, 2024
f5a9005
link: `SetKeyEvent` checks `IsExtendedKey(keyCode)`
jsoref Nov 29, 2024
117a8f4
link: IsExtendedKey
jsoref Nov 29, 2024
f389eba
link: Keyboard Input Overview: Extended-Key Flag
jsoref Nov 29, 2024
adbee7e
link: SetKeyEvent
jsoref Nov 29, 2024
fd78198
link: SetNumLockToPreviousState
jsoref Nov 29, 2024
50c5774
link: ResetIfModifierKeyForLowerLevelKeyHandlers
jsoref Nov 29, 2024
35bfcb6
link: emitted in `enable` and `disable`
jsoref Nov 29, 2024
2da761e
link: the end of `ApplySingleKeyRemappings`
jsoref Nov 29, 2024
f21d2bb
link: the end of `ApplyShortcutRemappings`
jsoref Nov 29, 2024
b0338ad
link: after calling `OSLevelShortcutRemapCount` in `ApplyShortcutRema…
jsoref Nov 29, 2024
91e0407
link: emitted [at the end of `start_lowlevel_keyboard_hook`
jsoref Nov 29, 2024
d4de3cf
link: list in `IgnoreKeyCode`
jsoref Nov 29, 2024
2201933
link: `OSLevelShortcutRemappingTests.cpp` and `AppSpecificShortcutRem…
jsoref Nov 29, 2024
504793c
link: SetKeyEventTests.cpp
jsoref Nov 29, 2024
4891cb1
link: [Keyboard Manager] Modernize the editor UI - PR#28473
jsoref Nov 29, 2024
b04e360
link: KeyboardManagerState.cpp lines 104-183
jsoref Nov 29, 2024
3a379d3
link: Project Structure
jsoref Nov 29, 2024
da30bc5
link: Launcher Telemetry
jsoref Nov 29, 2024
2f2d963
link: Flow of data between ViewModels and Plugins(Model)
jsoref Nov 29, 2024
3d04a50
link: Build apps with WinUI
jsoref Nov 29, 2024
402abce
link: Windows App SDK - Calling all Windows developers!
jsoref Nov 29, 2024
94fe424
link: Create and sign an assembly with a strong name by using Visual …
jsoref Nov 29, 2024
7900740
link: KeyDelay class
jsoref Nov 29, 2024
9db5898
link: Issue #6695
jsoref Nov 29, 2024
d4f78a0
link: this code in `KeyboardManagerState::AddOSLevelShortcut`
jsoref Nov 29, 2024
6e95abf
link: this call to `keyboardManagerState.RegisterKeyDelay`
jsoref Dec 1, 2024
47a0e84
spelling: a
jsoref Nov 29, 2024
9b5790e
spelling: an
jsoref Nov 29, 2024
ca359d0
spelling: applicationcan
jsoref Dec 1, 2024
b3aadb1
spelling: cannot
jsoref Nov 29, 2024
24aba2d
spelling: case-insensitive
jsoref Nov 29, 2024
2d18f57
spelling: case-sensitive
jsoref Nov 29, 2024
3f15552
spelling: control
jsoref Nov 29, 2024
7db38bf
spelling: every time
jsoref Nov 29, 2024
72c59d7
spelling: greater
jsoref Nov 29, 2024
18e51a1
spelling: its
jsoref Nov 29, 2024
fbe7390
spelling: [email protected]
jsoref Nov 29, 2024
9319226
spelling: powertoys
jsoref Dec 1, 2024
f2f30eb
spelling: the
jsoref Nov 29, 2024
71724c5
spelling: unknwn.h
jsoref Dec 2, 2024
ab3b25e
spelling: we'll
jsoref Dec 2, 2024
a9af770
Upgrade to check-spelling v0.0.24
jsoref Nov 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
link: onebranch (account required) under Localization
Signed-off-by: Josh Soref <[email protected]>
  • Loading branch information
jsoref committed Dec 5, 2024
commit e6cfa791a2775be5528b56ba98b34821fcdc1bbe
2 changes: 1 addition & 1 deletion doc/devdocs/localization.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ The [`Localization.XLoc`](https://github.com/microsoft/PowerToys/blob/86d77103e9

Since the localization script requires certain nuget packages, the [`restore-localization`](https://github.com/microsoft/PowerToys/blob/main/.pipelines/restore-localization.cmd) script is run before running `build-localization` to install all the required packages. This script must [run in the `restore` step](https://github.com/microsoft/PowerToys/blob/86d77103e9c69686c297490acb04775d43ef8b76/.pipelines/pipeline.user.windows.yml#L37-L39) of pipeline because [the host is network isolated](https://onebranch.visualstudio.com/Pipeline/_wiki/wikis/Pipeline.wiki/2066/Consuming-Packages-in-a-CDPx-Pipeline?anchor=overview) at the `build` step. The [Toolset package source](https://github.com/microsoft/PowerToys/blob/86d77103e9c69686c297490acb04775d43ef8b76/.pipelines/pipeline.user.windows.yml#L23) is used for this.

The process and variables that can be tweaked on the pipeline are described in more detail [here](https://onebranch.visualstudio.com/Pipeline/_wiki/wikis/Pipeline.wiki/290/Localization).
The process and variables that can be tweaked on the pipeline are described in more detail on [onebranch (account required) under Localization](https://onebranch.visualstudio.com/Pipeline/_wiki/wikis/Pipeline.wiki/290/Localization).

The localized resource dlls for C# projects are added to the MSI only for build on the pipeline. This is done by checking if the [`IsPipeline` variable is defined](https://github.com/microsoft/PowerToys/blob/f92bd6ffd38014c228544bb8d68d0937ce4c2b6d/installer/PowerToysSetup/Product.wxs#L804-L805), which gets defined before building the installer on the pipeline [here](https://github.com/microsoft/PowerToys/blob/f92bd6ffd38014c228544bb8d68d0937ce4c2b6d/.pipelines/build-installer.cmd#L4). This is done because the localized resx files are only present on the pipeline, and not having this check would result in the installer project failing to build locally.

Expand Down