-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New CI Pipeline for Latest WindowsAppSDK #36222
Conversation
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel with this, maybe it is time to migrate the cpp projects also over to a centralized prop like we did with the c# stuff.
project: '55e8140e-57ac-4e5f-8f9c-c7c15b51929d' | ||
definition: '104083' | ||
buildVersionToDownload: 'latestFromBranch' | ||
branchName: 'refs/heads/release/1.6-stable' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feels like it would change overtime, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project and definition IDs in Azure Pipelines are unique identifiers for a specific project and pipeline definition, respectively. These IDs do not change over time unless you explicitly delete and recreate the project or pipeline, which would generate new IDs.
} | ||
|
||
# Update .csproj files | ||
Get-ChildItem -Recurse *.csproj | ForEach-Object { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this just being safe in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just got the idea from the pipeline in WindowsAppSDK-Samples, it also did it in this way: https://github.com/microsoft/WindowsAppSDK-Samples/blob/main/UpdateVersions.ps1
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Pipeline can now specify the version of winappsdk to be used.
4dbdd3c
to
f983926
Compare
e65cfd9
to
50cbe10
Compare
3b6f86c
to
dd0e182
Compare
dd0e182
to
b888cf6
Compare
Doing some test for the code update, close it until the pipeline passed all the test. |
Summary
This PR introduces the following changes to the CI pipeline and version management:
Pipeline Enhancements:
UpdateVersions.ps1
to automate the update ofMicrosoft.WindowsAppSDK
versions across various project files.ci-using-the-latest-winappsdk.yml
to build using the latestMicrosoft.WindowsAppSDK
.useLatestWinAppSDK
parameter.Pipeline Configuration Updates:
job-build-project.yml
to handle theuseLatestWinAppSDK
parameter and adjust theRestoreAdditionalProjectSourcesArg
accordingly.steps-update-winappsdk-and-restore-nuget.yml
for updating and restoring NuGet packages with the latestMicrosoft.WindowsAppSDK
.PR Checklist
Detailed Description of the Pull Request / Additional comments
Changes
New Files
.pipelines/UpdateVersions.ps1
: Script to updateMicrosoft.WindowsAppSDK
versions..pipelines/v2/ci-using-the-latest-winappsdk.yml
: New pipeline configuration for using the latestMicrosoft.WindowsAppSDK
..pipelines/v2/templates/steps-update-winappsdk-and-restore-nuget.yml
: Template for updating and restoring NuGet packages.Modified Files
.pipelines/v2/templates/job-build-project.yml
: Updated to handleuseLatestWinAppSDK
parameter and adjust MSBuild arguments..pipelines/v2/templates/pipeline-ci-build.yml
: AddeduseLatestWinAppSDK
parameter.Validation Steps Performed
.pipelines/UpdateVersions.ps1
script correctly updates theMicrosoft.WindowsAppSDK
versions in the relevant project files.Microsoft.WindowsAppSDK
.verifyNoticeMdAgainstNugetPackages.ps1
based on theuseLatestWinAppSDK
parameter.