[PTRun]Use Mica backdrop to fix crashes with WPFUI #32118
Conversation
|
The lack of transparency on PTRun would likely affect more users than the random crash occurring rarely for some users right now... So this might be the wrong way to tackle it. |
|
mica should have a blurring effect |
|
@jaimecbernardo what does the background of your desktop look like? 😉 |
Black, indeed :) |
|
@crutkas Mica takes the colors of the desktop background only, not what's directly underneath 🤓 |
| @@ -32,9 +32,9 @@ | |||
|
|
|||
| <Grid x:Name="RootGrid" MouseDown="OnMouseDown"> | |||
| <!-- We set the background here because the Acrylic can be too translucent / background too bright on Light theme --> | |||
There was a problem hiding this comment.
I would remove all of this
There was a problem hiding this comment.
Got to be honest, that can be useful if we return to acrylic. Thinking of letting it in as I consider Niels to be the owner of those snippets :)
| @@ -63,7 +63,7 @@ public MainWindow(PowerToysRunSettings settings, MainViewModel mainVM, Cancellat | |||
|
|
|||
| if (OSVersionHelper.IsWindows11()) | |||
There was a problem hiding this comment.
- I thought the Mica backdrop automatically falls back to Acrylic, if not available??
- Why not set this in the XAML window?
There was a problem hiding this comment.
Thing is Mica is available. But some errors appear randomly to some users. We suspect graphics driver updates or something of the sort, but we haven't been able to repro.
This reverts commit b9da1e6.
…33458) * Revert "[PTRun]Fix accent on title bar bleed into UI (#33046)" This reverts commit 8bb5a33. * Revert "[PTRun]Use Mica backdrop to fix crashes with WPFUI (#32118)" This reverts commit b9da1e6. * Fix DWMAttributes in Wox Plugin Native Methods * Fix titlebar accent showing * Fix number on wrong enum
Summary of the Pull Request
Some users report that PowerToys Run fails with an error saying Desktop Composition is disabled, which makes no sense on Windows 10/11. Since we're using WPFUI with the Mica Backdrop without the same crash being reported, we're changing the backdrop type of PowerToys Run from Acrylic to Mica as well.
Before:
After:
This does seem to make PowerToys Run lose the blurred transparency it had before.
PR Checklist
Validation Steps Performed
PowerToys Run still works.