Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorts/Filters are not restored correctly. #13

Closed
stopyoukid opened this issue Jan 23, 2017 · 1 comment
Closed

Sorts/Filters are not restored correctly. #13

stopyoukid opened this issue Jan 23, 2017 · 1 comment
Assignees
Labels

Comments

@stopyoukid
Copy link
Member

No description provided.

@stopyoukid stopyoukid added the bug label Jan 24, 2017
@stopyoukid stopyoukid self-assigned this Jan 24, 2017
@stopyoukid
Copy link
Member Author

This looks like a problem in general, not just with Rank columns

stopyoukid added a commit that referenced this issue Jan 27, 2017
* PR 1160: Updated the value column to not wrap, but ellipsis, Fixes #2623

 - Updated the value column to not wrap, but ellipsis, Fixes #2623

Related work items: #2623

* PR 1161: Added a fix for some unexpected errors when switching quickly between two

 - Added a fix for some unexpected errors when switching quickly between two

Related work items: #2619, #2622

* PR 1170: Updated to typescript 2, fixed some imports, updated lineup which Fixes #2624

 - Updated to typescript 2, fixed some imports, updated lineup which Fixes #2624

Related work items: #2624

* PR 1171: Merge 2620-fix-numerical-filtering to develop

 - Fixed an issue with numerical filters not being applied to TableSorter via PBI,
 - Removed an unnecessary package change

Related work items: #2620

* Updating Artifacts

* Various restructuring updates (#3)

* PR 1287: Merge uncertainty to develop

 - Added some tweaks for lineup
 - Some initial work on uncertainty
 - Some more WIP
 - More WIP
 - Rename confidence to rank, and made the calculation a little fater
 - Reorganized the code a little
 - Did some renaming, moved around some of the color calculation code
 - Some settings reorg
 - Moved a lot of stuff around, fixed some issues
 - Some tweaks to the layout of settings
...

* Added licences

* Bumped PBI Base

* Added a description for the Rank column

* Added a docs test

* Added back the banner

* Updated the README

* Removed tasks folder

* Added some comments

* More comments

* Fixed a row rendering issue when lineup is embedded in an iframe, Fixes #2826

* Added some fixes for null values being hidden by default, Fixes #2802

* Added some fixes/tests for stacked columns

* Changed the null/undefined value handling in the weight sorting better

* Some more sorting/test fixes

* Updated so the rank column only works with numeric columns

* Fixed another small issue with sorting

* Missed a file

* Replaced the build tasks

* Added the force flag

* 0.10.0

* Merged PR 1342: Updated the wording of some of the settings, Fixes #2872

 - Updated the wording of some of the settings, Fixes #2872

Related work items: #2872

* Merged PR 1361: Added some logic to handle lower number == higher value and vice versa, and

 - Added some logic to handle lower number == higher value and vice versa, and

Related work items: #2911

* Made the rank column label generation slightly better

* Added some logic to allow for font coloring outside of rank mode

* Added a quick tweak to add histograms to rank columns

* 0.10.1

* Changed the index a little

* Fixed some test reference stuff

* Added some optional flags to some of the scss

* Fixed an issue where it would reuse old filters/sorts

* 0.10.2

* Added CI (#4)

* Added CI integration

* Added a missing setup script

* Marked the setup script as executable

* Added status badge

* Removed old npmrc

* Added githubUrl (#5)

* Added githubUrl

* Added package.json author

Closes #1

* Bumped the version on PBI base to get the github url support (#7)

* 0.10.3

* Comment Wording

* 13 sorts not restored (#14)

* Added logic to handle sorts not being restored, and moved around some tests

* Added more tests

* Added several tests

* Lint fix

Fixes #13

* 0.10.4

* Fixing by reverting "Release 0.10.3 (#9)"

This reverts commit d66e425.

* Updated circle.yml
stopyoukid added a commit that referenced this issue Jan 27, 2017
* PR 1160: Updated the value column to not wrap, but ellipsis, Fixes #2623

 - Updated the value column to not wrap, but ellipsis, Fixes #2623

Related work items: #2623

* PR 1161: Added a fix for some unexpected errors when switching quickly between two

 - Added a fix for some unexpected errors when switching quickly between two

Related work items: #2619, #2622

* PR 1170: Updated to typescript 2, fixed some imports, updated lineup which Fixes #2624

 - Updated to typescript 2, fixed some imports, updated lineup which Fixes #2624

Related work items: #2624

* PR 1171: Merge 2620-fix-numerical-filtering to develop

 - Fixed an issue with numerical filters not being applied to TableSorter via PBI,
 - Removed an unnecessary package change

Related work items: #2620

* Updating Artifacts

* Various restructuring updates (#3)

* PR 1287: Merge uncertainty to develop

 - Added some tweaks for lineup
 - Some initial work on uncertainty
 - Some more WIP
 - More WIP
 - Rename confidence to rank, and made the calculation a little fater
 - Reorganized the code a little
 - Did some renaming, moved around some of the color calculation code
 - Some settings reorg
 - Moved a lot of stuff around, fixed some issues
 - Some tweaks to the layout of settings
...

* Added licences

* Bumped PBI Base

* Added a description for the Rank column

* Added a docs test

* Added back the banner

* Updated the README

* Removed tasks folder

* Added some comments

* More comments

* Fixed a row rendering issue when lineup is embedded in an iframe, Fixes #2826

* Added some fixes for null values being hidden by default, Fixes #2802

* Added some fixes/tests for stacked columns

* Changed the null/undefined value handling in the weight sorting better

* Some more sorting/test fixes

* Updated so the rank column only works with numeric columns

* Fixed another small issue with sorting

* Missed a file

* Replaced the build tasks

* Added the force flag

* 0.10.0

* Merged PR 1342: Updated the wording of some of the settings, Fixes #2872

 - Updated the wording of some of the settings, Fixes #2872

Related work items: #2872

* Merged PR 1361: Added some logic to handle lower number == higher value and vice versa, and

 - Added some logic to handle lower number == higher value and vice versa, and

Related work items: #2911

* Made the rank column label generation slightly better

* Added some logic to allow for font coloring outside of rank mode

* Added a quick tweak to add histograms to rank columns

* 0.10.1

* Changed the index a little

* Fixed some test reference stuff

* Added some optional flags to some of the scss

* Fixed an issue where it would reuse old filters/sorts

* 0.10.2

* Added CI (#4)

* Added CI integration

* Added a missing setup script

* Marked the setup script as executable

* Added status badge

* Removed old npmrc

* Added githubUrl (#5)

* Added githubUrl

* Added package.json author

Closes #1

* Bumped the version on PBI base to get the github url support (#7)

* 0.10.3

* Comment Wording

* 13 sorts not restored (#14)

* Added logic to handle sorts not being restored, and moved around some tests

* Added more tests

* Added several tests

* Lint fix

Fixes #13

* 0.10.4

* Updated circle.yml
@stopyoukid stopyoukid changed the title Sorts/Filters are not restored when Rank columns are used. Sorts/Filters are not restored correctly. Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant