Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SARIF support #878 #944

Merged
merged 5 commits into from
Jan 31, 2022
Merged

Added SARIF support #878 #944

merged 5 commits into from
Jan 31, 2022

Conversation

BernieWhite
Copy link
Member

PR Summary

  • Added support for formatting results as SARIF.
    • Set Output.Format to Sarif to output results in the SARIF format.

Fixes #878

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Code changes
    • Have unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@BernieWhite BernieWhite requested a review from a team as a code owner January 30, 2022 16:12
ArmaanMcleod
ArmaanMcleod approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@ArmaanMcleod ArmaanMcleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BernieWhite looks great. I added some small code suggestions, let me know if your ok with them :).

@BernieWhite BernieWhite merged commit 94f5bc2 into microsoft:main Jan 31, 2022
@BernieWhite BernieWhite deleted the bewhite/sarif-878 branch January 31, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArmaanMcleod ArmaanMcleod ArmaanMcleod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for output using SARIF format
2 participants
@BernieWhite @ArmaanMcleod