Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conversion property to Less/Greater expressions #943

Closed
ArmaanMcleod opened this issue Jan 30, 2022 · 3 comments · Fixed by #1010
Closed

Add conversion property to Less/Greater expressions #943

ArmaanMcleod opened this issue Jan 30, 2022 · 3 comments · Fixed by #1010
Assignees
@BernieWhite
Labels
enhancement New feature or request feature: language Issues that affect language such keywords and variables
Milestone
v2.0.0

Comments

@ArmaanMcleod
Copy link
Contributor

ArmaanMcleod commented Jan 30, 2022 •
edited
Loading

Following up from #908,

The following expressions have conversion capability but currently are not exposed through the convert property introduced from the type expressions:

This is configurable with the equivalent assertions.
@ArmaanMcleod ArmaanMcleod added the enhancement New feature or request label Jan 30, 2022
@ArmaanMcleod
Copy link
Contributor Author

@BernieWhite Let me know if this is needed. I noticed this while doing the PR for type expressions.

@BernieWhite
Copy link
Member

@ArmaanMcleod Yes, we should make the expression implementation consistent with the assertions where possible.

@BernieWhite BernieWhite added the feature: language Issues that affect language such keywords and variables label Jan 30, 2022
@ArmaanMcleod ArmaanMcleod added this to the v2.0.0 milestone Jan 30, 2022
@ArmaanMcleod ArmaanMcleod self-assigned this Jan 30, 2022
@BernieWhite
Copy link
Member

@ArmaanMcleod As discussed. Re-assigning this one.

BernieWhite added a commit to BernieWhite/PSRule that referenced this issue Mar 11, 2022
@BernieWhite
Added convert to numeric expressions microsoft#943
9c6caa8
@BernieWhite BernieWhite mentioned this issue Mar 11, 2022
Merged
7 tasks
BernieWhite added a commit that referenced this issue Mar 12, 2022
@BernieWhite
Added convert to numeric expressions #943 (#1010)
b4ca7b4
@BernieWhite BernieWhite mentioned this issue Mar 15, 2022
Merged
4 tasks
@BernieWhite BernieWhite mentioned this issue Mar 25, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BernieWhite BernieWhite

Labels
enhancement New feature or request feature: language Issues that affect language such keywords and variables
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Added convert to numeric expressions #943 BernieWhite/PSRule
2 participants
@BernieWhite @ArmaanMcleod