-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for request body path parameters in v2 #922
Conversation
I decided not to implement writing re-used request bodies as path parameters in V2 for the following reasons:
This means that the way it is currently implemented, we can successfully read request bodies as Path Parameters from V2 documents but they will be converted into operation parameters during the read. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- changelog entry in the CSproj
src/Microsoft.OpenApi.Readers/V2/OpenApiPathItemDeserializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi.Readers/V2/OpenApiPathItemDeserializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi.Readers/V2/OpenApiPathItemDeserializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi.Readers/V2/OpenApiPathItemDeserializer.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Vincent Biret <[email protected]>
Co-authored-by: Vincent Biret <[email protected]>
Co-authored-by: Vincent Biret <[email protected]>
Co-authored-by: Vincent Biret <[email protected]>
I would rather use the release notes in the CSProj to point to the release notes on GitHub than worry about updating this file with a description of every change. |
Then may I suggest to log a new issue and have somebody on the team take care of that? |
Done #923 |
see #885