Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webhooks property to the root document #1046

Merged
merged 21 commits into from
Nov 3, 2022
Merged

Add webhooks property to the root document #1046

merged 21 commits into from
Nov 3, 2022

Conversation

MaggieKimani1
Copy link
Contributor

This PR:

  • Adds a root webhooks property to the OpenAPI document object model
  • Adds logic to serialize and deserialize the webhooks object
  • Adds tests

@MaggieKimani1 MaggieKimani1 mentioned this pull request Oct 24, 2022
Closed
11 tasks
@MaggieKimani1 MaggieKimani1 changed the title Add root webhooks property Add webhooks property to the root document Oct 24, 2022
baywet
baywet requested changes Oct 26, 2022
View reviewed changes
baywet
baywet approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the suggestions

@MaggieKimani1 MaggieKimani1 merged commit 093f761 into release/2.0.0 Nov 3, 2022
@MaggieKimani1 MaggieKimani1 deleted the mk/add-webhooks-property branch November 3, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaggieKimani1 @baywet