Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy OpenApiResponses object from source OpenApiOperation #1022

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Copy OpenApiResponses object from source OpenApiOperation #1022

merged 3 commits into from
Sep 26, 2022

Conversation

MaggieKimani1
Copy link
Contributor

@MaggieKimani1 MaggieKimani1 commented Sep 26, 2022 •
edited
Loading

Fixes #995
This PR:

  • Ensures Responses are copied over in the OpenApiOperation copy constructor
  • Adds a test case for validation
  • Bumps up lib version

@MaggieKimani1 MaggieKimani1 changed the title Copy OpenApiResponses object from source operation Copy OpenApiResponses object from source OpenApiOperation Sep 26, 2022
@MaggieKimani1 MaggieKimani1 merged commit e81a1c6 into vnext Sep 26, 2022
@MaggieKimani1 MaggieKimani1 deleted the mk/copy-responses-property branch September 26, 2022 12:09
@captainsafia captainsafia mentioned this pull request Sep 29, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenApiOperation copy constructor does not copy Responses property from source operation
2 participants
@MaggieKimani1 @baywet