Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graph vertex ordering during topological ordering #1546

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

shaahji
Copy link
Contributor

@shaahji shaahji commented Jan 11, 2025

Fix graph vertex ordering during topological ordering

Previous implementation returned vertices in reverse order even when there are no dependencies in the graph. Iterate the vertices in reverse order so input order can be retained.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

Disable checks for modules that use the same names as Python
standard-library modules.
Previous implementation returned vertices in reverse order even when there
are no dependencies in the graph. Iterate the vertices in reverse order so
input order can be retained.
@shaahji shaahji force-pushed the shaahji/consistency branch from 2201407 to 3fe4249 Compare January 13, 2025 06:23
@shaahji shaahji merged commit c1e1365 into main Jan 14, 2025
24 checks passed
@shaahji shaahji deleted the shaahji/consistency branch January 14, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants