Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing properties on export in SPOSite #5853

Open
wants to merge 2 commits into
base: Dev
Choose a base branch
from
+15 −12
Open

Fix missing properties on export in SPOSite #5853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
229322d
Fix missing properties on export in SPOSite
Feb 27, 2025
d7998b2
Remove non existing properties from export
FabienTschanz Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Change log for Microsoft365DSC

# UNRELEASED

* SPOSite
* Fixed an issue where the exported properties were not defined.
FIXES [#4773](https://github.com/microsoft/Microsoft365DSC/issues/4773)

# 1.25.226.1

* AADConditionalAccessPolicy
Expand Down
21 changes: 9 additions & 12 deletions Modules/Microsoft365DSC/DSCResources/MSFT_SPOSite/MSFT_SPOSite.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,6 @@ function Get-TargetResource
HubUrl = $CurrentHubUrl
Classification = $site.Classification
DisableFlows = $DisableFlowValue
LogoFilePath = $LogoFilePath
SharingCapability = $site.SharingCapability
StorageMaximumLevel = $site.StorageQuota
StorageWarningLevel = $site.StorageQuotaWarningLevel
Expand All @@ -252,18 +251,16 @@ function Get-TargetResource
DefaultSharingLinkType = $site.DefaultSharingLinkType
DisableAppViews = $site.DisableAppViews
DisableCompanyWideSharingLinks = $site.DisableCompanyWideSharingLinks
DisableSharingForNonOwners = $DisableSharingForNonOwners
LocaleId = $site.LocaleId
RestrictedToRegion = $RestrictedToRegion
SocialBarOnSitePagesDisabled = $SocialBarOnSitePagesDisabled
SiteDesign = $SiteDesign
RestrictedToRegion = $site.RestrictedToGeo
SocialBarOnSitePagesDisabled = $site.SocialBarOnSitePagesDisabled
DenyAddAndCustomizePages = $DenyAddAndCustomizePagesValue
SharingAllowedDomainList = $SharingAllowedDomainList
SharingBlockedDomainList = $SharingBlockedDomainList
SharingDomainRestrictionMode = $SharingDomainRestrictionMode
ShowPeoplePickerSuggestionsForGuestUsers = $ShowPeoplePickerSuggestionsForGuestUsers
AnonymousLinkExpirationInDays = $AnonymousLinkExpirationInDays
OverrideTenantAnonymousLinkExpirationPolicy = $OverrideTenantAnonymousLinkExpirationPolicy
SharingAllowedDomainList = $site.SharingAllowedDomainList
SharingBlockedDomainList = $site.SharingBlockedDomainList
SharingDomainRestrictionMode = $site.SharingDomainRestrictionMode
ShowPeoplePickerSuggestionsForGuestUsers = $site.ShowPeoplePickerSuggestionsForGuestUsers
AnonymousLinkExpirationInDays = $site.AnonymousLinkExpirationInDays
OverrideTenantAnonymousLinkExpirationPolicy = $site.OverrideTenantAnonymousLinkExpirationPolicy
Ensure = 'Present'
Credential = $Credential
ApplicationId = $ApplicationId
Expand Down Expand Up @@ -974,7 +971,7 @@ function Export-TargetResource
CertificatePassword = $CertificatePassword
CertificatePath = $CertificatePath
CertificateThumbprint = $CertificateThumbprint
Managedidentity = $ManagedIdentity.IsPresent
ManagedIdentity = $ManagedIdentity.IsPresent
Credential = $Credential
AccessTokens = $AccessTokens
}
Expand Down