Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix credential export and indentation in export, ReverseDSC improvements #5767

Merged
merged 6 commits into from
Feb 17, 2025

Conversation

FabienTschanz
Copy link
Collaborator

@FabienTschanz FabienTschanz commented Feb 13, 2025

Pull Request (PR) description

This PR fixes an issue where the Credential property in an export would be escaped and the indentation of an export is incorrect. It also adds the possibility to exclude the authentication properties from being updated as well as to allow variables in strings during final export conversion.

ATTENTION: Requires that microsoft/ReverseDSC#45 is merged first with an updated ReverseDSC version!

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

@FabienTschanz FabienTschanz changed the title Fix credential export and indentation in export Fix credential export and indentation in export, ReverseDSC improvements Feb 13, 2025
@FabienTschanz
Copy link
Collaborator Author

@NikCharlebois This PR and microsoft/ReverseDSC#45 belong together, and both are quite important for functionality to work properly. I found a couple of indentation issues and a nasty surprise with the Credential property in the resources that need to be resolved quickly so the customers don't generate invalid exports.

@ricmestre I believe all your issues should be addressed after this PR is merged.

@NikCharlebois NikCharlebois merged commit e8d0861 into microsoft:Dev Feb 17, 2025
3 checks passed
@FabienTschanz FabienTschanz deleted the fix/credential-export branch February 17, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The term '$Credscredential' is not recognized
3 participants