Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional properties to SPOTenantSettings #5749

Merged

Conversation

JuliusRauschen
Copy link
Contributor

Pull Request (PR) description

This PR adds additional properties to SPOTenantSettings

This Pull Request (PR) fixes the following issues

None

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

@NikCharlebois
Copy link
Collaborator

I believe most of the properties are already available as part of the SPOSharingSettings resource. Please confirm.

@JuliusRauschen
Copy link
Contributor Author

All properties except EnableAzureADB2BIntegration and OneDriveSharingCapability where already present in SPOSharingSettings. These are now removed.

@FabienTschanz
Copy link
Collaborator

@NikCharlebois LGTM

@NikCharlebois NikCharlebois merged commit 711f0dc into microsoft:Dev Feb 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants