Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Devices as member to AADGroup #5660

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Conversation

AlfredSchreuder
Copy link
Contributor

Pull Request (PR) description

  • Added functionality to add & check on Devices in AAD groups.

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

@AlfredSchreuder
Copy link
Contributor Author

Sorry for that it seems many code changes, which are caused by and Shift-tab (indentation fix) to line up with the rest of the code. The first code addition is actually only line 222-225, rest is the shift-tab in the line 204-233 section.

@ykuijs
Copy link
Member

ykuijs commented Jan 27, 2025

Please update with Dev. There seems to be something strange going on in the Changelog.....I am missing the previous version in there.

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some corrections in the changelog.

@AlfredSchreuder
Copy link
Contributor Author

AlfredSchreuder commented Jan 27, 2025

@ykuijs Should be fixed now, I opened the PR just before the last release, I think.

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs ykuijs merged commit 655e2e4 into microsoft:Dev Jan 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants