Fix Platform and TargetFramework switching #70
Conversation
|
looks reasonable to me |
| @@ -12,4 +12,8 @@ | |||
| <UnityMajorVersion><!--UNITY_MAJOR_VERSION_TOKEN--></UnityMajorVersion> | |||
| <UnityMinorVersion><!--UNITY_MINOR_VERSION_TOKEN--></UnityMinorVersion> | |||
| </PropertyGroup> | |||
|
|
|||
| <Target Name="_RemoveOutputDirectory" AfterTargets="Clean"> | |||
There was a problem hiding this comment.
I'm still unclear why this is needed. If I create a default SDK style project and add a package reference to MSBuildForUnity and Newtonsoft.Json, it behaves like I would expect: build results in the project dll plus the Newtonsoft dll in the output directory, and clean removes all files from the output directory.
There was a problem hiding this comment.
That is not what I am seeing, and there are GitHub issues detailing similar problems:
dotnet/msbuild#2408
Unless I am misunderstanding something, would be great to see an example to understand what I am doing wrong.
There was a problem hiding this comment.
I found the issue, and don't know how to fix it. Basically if the OutputPath of the project is under the directory that the project is contained in, then Clean works as expected; otherwise Clean doesn't remove the NuGet package output.
Opened #71.
* Rework automatic generation logic, and ensure cleanning of build artifacts is done at appropriate times. * Removing debug logs. * A few minor fixes to strengthen regen for correct times. * Updated versions to 0.8.2 * Forcing NuGet packages to be copied out to bin folder
This change improves how the project handles platform and target framework (API Compatibility set) changes. Furthermore, it makes sure to appropriately clean-up before making the switch.
This increments the version to 0.8.2 for the hotfix.
This PR is against the prerelease/0.8.2 branch which is essentially the release/0.8.1. Once we approve, I will rename prerelease/0.8.2 to release/0.8.2 and push a release.