Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin a devcontainer version to workaround library search path issue #699

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Mar 6, 2024

A new base devcontainer image was released recently that introduces the following error in our environment when running make test:

 import pandas._libs.window.aggregations as window_aggregations\n'
 'ImportError: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version '
 "`GLIBCXX_3.4.29' not found (required by "
 '/opt/conda/envs/mlos/lib/python3.11/site-packages/pandas/_libs/window/aggregations.cpython-311-x86_64-linux-gnu.so)\n')

A simplified reproduction involves running conda run -n mlos pytest mlos_bench/mlos_bench/launcher_run_test.ph.

Unfortunately, it appears that under the latest version somewhere between conda and pytest the libc.so.6 library found is the one under /usr/lib instead of /opt/conda/envs/mlos/lib.

I haven't quite seen where that's happening, but I've confirmed that rolling back to the previous release for the base devcontainer image fixes it.

Note that even then, we update conda to the latest and no-cache update our own dependencies nightly, so we are getting the latest conda at least, if not the latest Debian base packages.

This will be somewhat of a security issue eventually, but for now it frees up our CI pipeline to get moving again.

@bpkroth bpkroth requested a review from a team as a code owner March 6, 2024 18:22
@bpkroth bpkroth enabled auto-merge (squash) March 6, 2024 18:50
@bpkroth bpkroth added ready for review Ready for review dependencies Pull requests that update a dependency file ci labels Mar 6, 2024
@bpkroth bpkroth merged commit de9e35d into microsoft:main Mar 6, 2024
12 checks passed
@bpkroth bpkroth deleted the fixup-devcontainer branch March 6, 2024 20:23
bpkroth added a commit that referenced this pull request Mar 6, 2024
Fixup following the commit message from #699 which includes a backtick
command.
bpkroth added a commit that referenced this pull request Mar 7, 2024
- Update the base image and make sure related dependencies are
consistently from either pip or conda, but not both (follow on fixes to
#699)
- Minor tweak to include the PATH in the local script exec environment
variables
- Another fix to the CI issue in #703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci dependencies Pull requests that update a dependency file ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants