Add GridSearch Optimizer support #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gh the grid in order
motus
reviewed
Mar 1, 2024
There was a problem hiding this comment.
Left a few comments. To summarize:
- let's have a separate PR with type-related fixes to the Tunable and related classes
- remove .span/.values/.quantized_values from Tunable and move that logic to the optimizer
- I am sure we can do without HashableTunableValuesDict class. I would suggest to track the tuples of tunable values in the optimizer instead of using the dict (should use less memory, too)
bpkroth
added a commit
that referenced
this pull request
Mar 5, 2024
Also fix some missing conversion issues. Split out from #690.
bpkroth
added a commit
that referenced
this pull request
Mar 6, 2024
Some type hint and alias tweaks for Tunables and a few others. Split off from #690.
bpkroth
added a commit
that referenced
this pull request
Mar 6, 2024
Adds support for introspecting the values from a quantized or otherwise discrete Tunable. Split out from #690.
motus
reviewed
Mar 7, 2024
Co-authored-by: Sergiy Matusevych <[email protected]>
Co-authored-by: Sergiy Matusevych <[email protected]>
Co-authored-by: Sergiy Matusevych <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #688
GridSearchOptimizertomlos_benchtuple(dict.values())fromConfigSpaceto track elements of the config grid to searchmax_iterations>len(grid)can refill the grid if desired (e.g., by callingsuggest()afternot_converged()returnsFalse.max_iterations<len(grid)(i.e., we don't have enough iterations to complete the grid) will issue a warning.