-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return status and actual timestamp from all environments #671
Conversation
…reate a status record in teh database
Not sure I agree with this, but maybe I just am not following where you're heading with it. I think we need to store two separate things:
However, if implement this with a single table, then the latter requires messy aggregates over the former to find out the overall status of each current trial. I think that should probably just be stored as a single column in the Thoughts? |
Co-authored-by: Brian Kroth <[email protected]>
I think we are on the same page. This is exactly how I want to implement this. I will remove all DB-related code from this PR and move it to the next one that actually implements the queue - i.e., with the corresponding read method, unit tests, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is the first step to making trials asynchronous. In this PR we just make sure every Environment method that returns status also returns the timestamp of that status. In the next PR we will get these timestamps and status values from the remote environment.