-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for mixed numerical type conversions of tunable config data from storage #670
Conversation
… from storage Closes microsoft#669
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good + a few nitpicks.
P.S. I don't quite like that the mixed_numerics_exp_storage
fixture returns an experiment detached from its context (i.e., after Experiment._teardown()
has been called internally), but I guess that's ok for tests. I'll think about it later.
Co-authored-by: Sergiy Matusevych <[email protected]>
Co-authored-by: Sergiy Matusevych <[email protected]>
Co-authored-by: Sergiy Matusevych <[email protected]>
I actually copied that one from your original |
Actually, we might need to use |
Fixups to address discussions in #670
Closes #669