[ci] consolidate R package installs into a CI script #6808
+86
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
commented
Feb 3, 2025
| @@ -65,7 +65,7 @@ jobs: | |||
| shell: bash | |||
| # yamllint disable rule:line-length | |||
| run: | | |||
| Rscript -e "install.packages(c('R6', 'data.table', 'jsonlite', 'knitr', 'markdown', 'Matrix', 'RhpcBLASctl', 'roxygen2', 'testthat'), repos = 'https://cran.rstudio.com', Ncpus = parallel::detectCores())" | |||
| Rscript ./.ci/install-r-deps.R --build --roxygen | |||
There was a problem hiding this comment.
Notice... {testthat} and all its dependencies were being installed unnecessarily here! So this change should also make the static analysis job a little faster 🎉
jameslamb
commented
Feb 3, 2025
.ci/test-r-package-windows.ps1
Outdated
Comment on lines
180
to
181
| # $command_args_patch = "commandArgs <- function(...){c('--build', '--test')};" | ||
| # Invoke-R-Code-Redirect-Stderr "$command_args_patch source('install-r-deps.R')" ; Assert-Output $? |
There was a problem hiding this comment.
Suggested change
| # $command_args_patch = "commandArgs <- function(...){c('--build', '--test')};" | |
| # Invoke-R-Code-Redirect-Stderr "$command_args_patch source('install-r-deps.R')" ; Assert-Output $? |
This seems to work ok without the more complicated Invoke-R-Code-Redirect-Stderr pattern 😁
jameslamb
changed the title
jameslamb
requested review from
guolinke,
shiyu1994,
jmoralez,
borchero and
StrikerRUS
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6804 (comment)
Consolidates the various
install.packages()calls across the project's CI into a single.ci/script.Notes for Reviewers
I'm intentionally not proposing updating user-facing docs like this:
LightGBM/R-package/README.md
Lines 429 to 431 in 425395d
I'd like to keep this script limited to LightGBM's CI, and changeable at any time. I don't want to make it a part of the public interface of the project or encourage anyone else to use it.