-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] check PowerShell scripts with PSScriptAnalyzer (part 3) #6710
Conversation
@@ -53,4 +53,4 @@ $settings = @{ | |||
} | |||
} | |||
|
|||
Invoke-ScriptAnalyzer -Path "$env:BUILD_DIRECTORY/.ci" -Recurse -EnableExit -Settings $settings | |||
Invoke-ScriptAnalyzer -Path ./ -Recurse -EnableExit -Settings $settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for the consistency with other our linting scripts.
Lines 6 to 9 in 92aa07b
cpplint \ | |
--filter=-build/c++11,-build/include_subdir,-build/header_guard,-whitespace/line_length \ | |
--recursive ./src ./include ./R-package ./swig ./tests \ | |
|| exit 1 |
Lines 10 to 12 in 92aa07b
mypy \ | |
--config-file=./python-package/pyproject.toml \ | |
./python-package \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I agree, I think this makes the scripts a little easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks! I left one very very small question, do whatever you want with it.
Co-authored-by: James Lamb <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enclose more paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approving, thanks for all the additional quoting.
Linking full original PR: #6700.
Continuation of #6709.
Closed #6498.
Closed #6700.
This PR fixes all remaining PowerShell linting issues (
PSAvoidLongLines
,PSAvoidUsingCmdletAliases
,PSPlaceCloseBrace
,PSPossibleIncorrectComparisonWithNull
).Helpful links with info about splitting long lines: