Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] add shellcheck, use latest pre-commit hook versions #6685

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

jameslamb
Copy link
Collaborator

Contributes to #6498

  • enforces shellcheck checks in CI
  • updates all pre-commit hooks to their latest versions (via pre-commit autoupdate)

Fixes 1 new warning found by ruff

python-package/lightgbm/basic.py:879:17: PLR1730 [*] Replace `if` statement with `offset = max(offset, max_offset)

Notes for reviewers

Double-checked, and shellcheck-py ships wheels for Linux, Windows, and macOS ... so everyone working on the project should be able to keep running pre-commit without issue.

ref: https://pypi.org/project/shellcheck-py/#files

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, very nice!

@StrikerRUS StrikerRUS merged commit 283cdde into master Oct 17, 2024
48 checks passed
@StrikerRUS StrikerRUS deleted the ci/shellcheck branch October 17, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants