Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] resolve shellcheck errors in .ci/check_python_dists.sh #6503

Merged
merged 10 commits into from
Jul 4, 2024
Merged

[ci] resolve shellcheck errors in .ci/check_python_dists.sh #6503

merged 10 commits into from
Jul 4, 2024

Conversation

Kunal-Singh-Dadhwal
Copy link
Contributor

Contributing to #6498 , So in the file .ci/check_python_dists.sh the errors raise by shellcheck were

In .ci/check_python_dists.sh line 3:
set -e -E -u
       ^-- SC3041 (warning): In POSIX sh, set flag -E is undefined.

So I changes the shebang line from #!/bin/sh to #!/bin/bash

Then shellcheck was giving errors based on SC2086 i.e.

In .ci/check_python_dists.sh line 23:
    check-wheel-contents ${DIST_DIR}/*.whl || exit 1
                         ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

The same errors were also on line 19,37,45,52 which can be resolved by changing ${DIST_DIR}/* to "${DIST_DIR}/*"

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help. Please see the first round of comments here.

.ci/check_python_dists.sh Outdated Show resolved Hide resolved
.ci/check_python_dists.sh Outdated Show resolved Hide resolved
.ci/check_python_dists.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the cases with wildcards.

.ci/check_python_dists.sh Outdated Show resolved Hide resolved
.ci/check_python_dists.sh Outdated Show resolved Hide resolved
.ci/check_python_dists.sh Outdated Show resolved Hide resolved
@jameslamb jameslamb self-requested a review July 4, 2024 03:35
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the help!

@jameslamb jameslamb merged commit a8b7078 into microsoft:master Jul 4, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants