-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] resolve shellcheck errors in .ci/check_python_dists.sh #6503
[ci] resolve shellcheck errors in .ci/check_python_dists.sh #6503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the help. Please see the first round of comments here.
Co-authored-by: James Lamb <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the cases with wildcards.
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the help!
Contributing to #6498 , So in the file
.ci/check_python_dists.sh
the errors raise by shellcheck wereSo I changes the shebang line from
#!/bin/sh
to#!/bin/bash
Then shellcheck was giving errors based on SC2086 i.e.
The same errors were also on line 19,37,45,52 which can be resolved by changing
${DIST_DIR}/*
to"${DIST_DIR}/*"