Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] remove unnecessary workarounds in R-package macOS jobs #6331

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

jameslamb
Copy link
Collaborator

In #6266, I'm working on making this project's shell scripts stricter, so they exit with a non-0 exit code the first time anything goes wrong (e.g. some variable they require isn't set or somme command they run fails).

This revealed that 2 workarounds in .ci/test_r_package.sh that are no longer necessary:

Those have both been unnecessary and not working for a while, as can be seen by messages like this in CI:

ln: /Library/Frameworks/R.framework/Versions/4.3/Resources/lib/libomp.dylib: No such file or directory

(link to recent build from master)

This removes those workarounds, simplifying the testing setup a bit.

@jameslamb jameslamb changed the title WIP: [ci] remove unnecessary workarounds in R-package macOS jobs [ci] remove unnecessary workarounds in R-package macOS jobs Feb 20, 2024
@jameslamb jameslamb marked this pull request as ready for review February 20, 2024 02:51
@jameslamb jameslamb merged commit 008ebaf into master Feb 20, 2024
43 checks passed
@jameslamb jameslamb deleted the ci/r-mac-workarounds branch February 20, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants