Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] enforce dask version to be >=2023.5.0 in some builds (fixes #6030) #6032

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

shiyu1994
Copy link
Collaborator

Try to fix #6030.

@jameslamb
Copy link
Collaborator

Hey that worked! The Python 3.8 macOS job is succeeding now!

It's just the 3.7 jobs that are unhappy about this new version constraint: https://github.com/microsoft/LightGBM/actions/runs/5833746769/job/15821827877?pr=6032

UnsatisfiableError: The following specifications were found to be incompatible with each other:

Output in format: Requested package -> Available versions

Package importlib_metadata conflicts for:
pytest -> importlib_metadata[version='>=0.12']
pytest -> pluggy[version='>=0.9'] -> importlib_metadata[version='>=0.9']
distributed[version='>=2023.5.0'] -> dask-core[version='>=2023.8.0,<2023.8.1.0a0'] -> importlib_metadata[version='>=4.13.0']
dask-core[version='>=2023.5.0'] -> importlib_metadata[version='>=4.13.0']

I can push a commit to fix that.

@jameslamb jameslamb changed the title [WIP][ci] enforce dask version to be >=2023.5.0 [WIP][ci] enforce dask version to be >=2023.5.0 in some builds (fixes #6030) Aug 11, 2023
@jameslamb
Copy link
Collaborator

Just pushed 02adfa7, to add a special case for Python 3.7 jobs.

Also @shiyu1994 I removed the fix label from this PR, so it'll just be classified as maintenance. I'm not sure how the automatic release notes drafter will handle a PR that has two of the labels it looks for.

categories:
- title: '💡 New Features'
label: 'feature'
- title: '🔨 Breaking'
label: 'breaking'
- title: '🚀 Efficiency Improvement'
label: 'efficiency'
- title: '🐛 Bug Fixes'
label: 'fix'
- title: '📖 Documentation'
label: 'doc'
- title: '🧰 Maintenance'
label: 'maintenance'

@jameslamb jameslamb removed the fix label Aug 11, 2023
@shiyu1994 shiyu1994 changed the title [WIP][ci] enforce dask version to be >=2023.5.0 in some builds (fixes #6030) [ci] enforce dask version to be >=2023.5.0 in some builds (fixes #6030) Aug 11, 2023
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me like this patch will work!

Thanks so much for working to quickly fix this @shiyu1994

@shiyu1994 shiyu1994 merged commit fe838d8 into master Aug 11, 2023
@shiyu1994 shiyu1994 deleted the ci/fix-dask-pandas-conflict branch August 11, 2023 16:20
@jameslamb
Copy link
Collaborator

Ha I was JUST about to click the button, you beat me to it @shiyu1994 😆

Thanks for the help with this.

Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot removed the blocking label Nov 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] [ci] Dask compatibility with Python 3.8 and Pandas 2.0
2 participants