Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Handle deprecated fields to adapt to history versions of Gradle & Azure plugin #644

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Bugfix: Handle deprecated fields to adapt to history versions of Gradle & Azure plugin #644

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
021cb8d
Bugfix: Handle deprecated fields to adapt to history versions of Grad…
zhou9584 Jan 22, 2024
317bac8
Update Task.java
zhou9584 Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions center/src/main/java/com/microsoft/hydralab/center/service/TestDataService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,11 @@ public Task getTaskDetail(String id) {
deviceTestResult.setAttachments(attachmentService.getAttachments(deviceTestResult.getId(), EntityType.TEST_RESULT));
deviceTestResult.setTaskResult(taskResultRepository.findByTaskRunId(deviceTestResult.getId()).orElse(null));
}

// for deprecated field
task.getDeviceTestResults().addAll(byTestTaskId);
task.setTestDevicesCount(task.getDeviceCount());
task.setTestErrorMsg(task.getErrorMsg());
return task;
}

Expand Down
12 changes: 12 additions & 0 deletions common/src/main/java/com/microsoft/hydralab/common/entity/common/Task.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,18 @@ public class Task implements Serializable {
@Transient
private boolean disableRecording = false;

@Transient
@Deprecated
private List<TestRun> deviceTestResults = new ArrayList<>();

@Transient
@Deprecated
private int testDevicesCount;

@Transient
@Deprecated
private String testErrorMsg;

public synchronized void addTestedDeviceResult(TestRun deviceTestResult) {
taskRunList.add(deviceTestResult);
}
Expand Down
Loading