Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependent packages showing up as changed in getAffectedPackages #786

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

jakebailey
Copy link
Member

Fixes DefinitelyTyped/DefinitelyTyped#67205

I think I probably incorrectly suggested the bad code in a change, not understanding what this code did. This just removes ... which gives the right answer on DT:

[email protected]
Node version:  v20.9.0
Using local DefinitelyTyped at .
Running: git rev-parse --verify master
d0df83268470773861ff1bd2a6a9520b8c247d3d
Running: git diff master --name-status
M       types/node/v18/child_process.d.ts
M       types/node/v18/test/child_process.ts
Testing 1 changed packages: Set(1) { 'node/v18' }
Testing 9 dependent packages: Set(9) {
  'ssh2',
  'docker-modem',
  'dockerode',
  'docker-events',
  'node-ssh',
  'promise-sftp',
  'ssh2-sftp-client',
  'ssh2-sftp-client/v7',
  'tunnel-ssh'
}

Comment on lines 60 to 62
console.log("changedPackageDirectories", changedPackageDirectories);
console.log("addedPackageDirectories", addedPackageDirectories);
console.log("allDependentDirectories", allDependentDirectories);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we log similar derived information a little bit later? It's useful but probably overwhelming especially for large changes.

No recommendation, just an observation. More logging is better than none, so I guess leave it in.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to push, this is not supposed to be there!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(pushed now...)

@jakebailey
Copy link
Member Author

Meta point, but would be nice to set up some sort of test DT that we can test these pnpm commands in or something.

@jakebailey jakebailey merged commit c8d8b1f into microsoft:master Oct 26, 2023
@jakebailey jakebailey deleted the fix-affected-packages branch October 26, 2023 22:05
@peterblazejewicz
Copy link
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@types/node]DangerBotOSS
3 participants