Update line ending detection on configuration name replace #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@NikCharlebois
This Pull Request updates the behavior for the next line ending detection when trying to replace the configuration name in
ConvertTo-DscObject
. The next line ending is checked for carriage return + line feed, but the line might only contain a line feed without carriage return (e.g. when usingM365DSCRuleEvaluation
, which contains an inline configuration definition which is only made of line feeds, without the carriage returns).Without that updated line feed detection, not only the configuration name will be replaced, but everything down to the first resource definition, which then results in an incorrectly parsed DSC configuration.