Skip to content

Commit

Permalink
Remove default mountOptions for blobfuse (#721)
Browse files Browse the repository at this point in the history
  • Loading branch information
Anbang-Hu authored Dec 26, 2019
1 parent 02a82d2 commit 1d0e769
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
2 changes: 0 additions & 2 deletions src/Jobs_Templete/pod.yaml.template
Original file line number Diff line number Diff line change
Expand Up @@ -337,8 +337,6 @@ spec:
{% endif %}
{% if bf["mountOptions"] %}
mountoptions: {{ bf["mountOptions"] }}
{% else %}
mountoptions: "--file-cache-timeout-in-seconds=120"
{% endif %}
{% endif %}
{% endfor %}
Expand Down
8 changes: 4 additions & 4 deletions src/dashboard/src/pages/Submission/Training.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ const Training: React.ComponentClass = withRouter(({ history }) => {
const [accountKey, setAccountKey] = React.useState("");
const [containerName, setContainerName] = React.useState("");
const [mountPath, setMountPath] = React.useState("");
const [mountOptions, setMountOptions] = React.useState("--file-cache-timeout-in-seconds=120");
const [mountOptions, setMountOptions] = React.useState("");
const onAccountNameChange = React.useCallback(
(event: React.ChangeEvent<HTMLInputElement>) => {
setAccountName(event.target.value);
Expand Down Expand Up @@ -379,7 +379,7 @@ const Training: React.ComponentClass = withRouter(({ history }) => {
blobfuseObj['accountKey'] = accountKey || '';
blobfuseObj['containerName'] = containerName || '';
blobfuseObj['mountPath'] = mountPath || '';
blobfuseObj['mountOptions'] = mountOptions;
blobfuseObj['mountOptions'] = mountOptions || '';
plugins['blobfuse'].push(blobfuseObj);

plugins['imagePull'] = [];
Expand Down Expand Up @@ -525,7 +525,7 @@ const Training: React.ComponentClass = withRouter(({ history }) => {
setAccountKey("");
setContainerName("");
setMountPath("");
setMountOptions("--file-cache-timeout-in-seconds=120");
setMountOptions("");
setDockerRegistry("")
setDockerUsername("")
setDockerPassword("")
Expand Down Expand Up @@ -593,7 +593,7 @@ const Training: React.ComponentClass = withRouter(({ history }) => {
blobfuseObj['accountKey'] = accountKey || '';
blobfuseObj['containerName'] = containerName || '';
blobfuseObj['mountPath'] = mountPath || '';
blobfuseObj['mountOptions'] = mountOptions;
blobfuseObj['mountOptions'] = mountOptions || '';
plugins['blobfuse'].push(blobfuseObj);
plugins['imagePull'] = [];
let imagePullObj: any = {};
Expand Down

0 comments on commit 1d0e769

Please sign in to comment.