Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent: fix DTMF key command usage #5198

Merged
merged 4 commits into from
May 28, 2024
Merged

Fluent: fix DTMF key command usage #5198

merged 4 commits into from
May 28, 2024

Conversation

OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented May 28, 2024

Fixes #5197

Changelog Entry

  • Fixed DTMF command usage sent by telephone keypad, in PR 5198, by @OEvgeny

Description

Fixed according to the linked issue suggestion

Design

Specific Changes

  • Rename /DTMF to /DTMFKey command
  • Adjust tests

-

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny marked this pull request as ready for review May 28, 2024 20:55
@compulim compulim enabled auto-merge (squash) May 28, 2024 21:53
@compulim compulim merged commit 6ff90db into main May 28, 2024
25 checks passed
@compulim compulim deleted the fix/dtmf-key branch May 28, 2024 22:01
OEvgeny added a commit that referenced this pull request May 30, 2024
* Fix DTMF key command usage

* Changelog

* Fix star and pound
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fluent UI] Should send /DTMFKey 1 instead of /DTMF 1
2 participants