[JS Sample 15] Fix for image attachments #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengum
approved these changes
Mar 13, 2019
| // arraybuffer is necessary for images | ||
| const response = await axios.get(url, { responseType: 'arraybuffer' }); | ||
| // If user uploads JSON file, this prevents it from being written as "{"type":"Buffer","data":[123,13,10,32,32,34,108..." | ||
| if (response.headers['content-type'] === 'application/json') { |
stevengum
pushed a commit
that referenced
this pull request
Mar 14, 2019
sgellock
pushed a commit
that referenced
this pull request
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1293
Per issue, without this change, an attached/uploaded image or PDF (likely some other file formats, too) would corrupt while saving locally. @Zerryth and I found that this fixes it.
Proposed Changes
When calling
downloadAttachmentAndWrite(attachment):application/json, converts before saving to prevent.jsonfile content being something like: "{"type":"Buffer","data":[123,13,10,32,32,34,108..."Testing
Tested with the following filetypes:
They all work.