Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Cloud Role Name for Quickpulse SDK #2100

Merged
merged 10 commits into from
Oct 30, 2020
Merged

Add Support for Cloud Role Name for Quickpulse SDK #2100

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c81df2f
initial commit
rambhatt-msft Oct 15, 2020
181ec9e
Merge branch 'develop' into rambhatt/roles-support
rambhatt-msft Oct 27, 2020
de3478b
fix blank space issue
rambhatt-msft Oct 27, 2020
a695064
fix blank space issue
rambhatt-msft Oct 27, 2020
d72ee50
address PR comments
rambhatt-msft Oct 27, 2020
a10053d
fix build errors in release mode
rambhatt-msft Oct 27, 2020
5c7d99d
address PR comments 2
rambhatt-msft Oct 28, 2020
bddeaa3
address PR comments 3
rambhatt-msft Oct 28, 2020
1974d96
add changelog comments
rambhatt-msft Oct 30, 2020
4b8e562
add changelog comment
rambhatt-msft Oct 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...ormanceCollector/Perf.Shared.NetFull/Implementation/QuickPulse/QuickPulseServiceClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ internal sealed class QuickPulseServiceClient : IQuickPulseServiceClient
{
private readonly string instanceName;

private readonly string roleName;

private readonly string streamId;

private readonly string machineName;
Expand All @@ -45,6 +47,7 @@ internal sealed class QuickPulseServiceClient : IQuickPulseServiceClient
public QuickPulseServiceClient(
Uri serviceUri,
string instanceName,
string roleName,
string streamId,
string machineName,
string version,
Expand All @@ -55,6 +58,7 @@ public QuickPulseServiceClient(
{
this.ServiceUri = serviceUri;
this.instanceName = instanceName;
this.roleName = roleName;
this.streamId = streamId;
this.machineName = machineName;
this.version = version;
Expand Down Expand Up @@ -230,6 +234,7 @@ private void WritePingData(DateTimeOffset timestamp, Stream stream)
InvariantVersion = MonitoringDataPoint.CurrentInvariantVersion,
// InstrumentationKey = instrumentationKey, // ikey is currently set in query string parameter
Instance = this.instanceName,
RoleName = this.roleName,
StreamId = this.streamId,
MachineName = this.machineName,
Timestamp = timestamp.UtcDateTime,
Expand Down Expand Up @@ -268,6 +273,7 @@ private void WriteSamples(IEnumerable<QuickPulseDataSample> samples, string inst
InvariantVersion = MonitoringDataPoint.CurrentInvariantVersion,
InstrumentationKey = instrumentationKey,
Instance = this.instanceName,
RoleName = this.roleName,
StreamId = this.streamId,
MachineName = this.machineName,
Timestamp = sample.EndTimestamp.UtcDateTime,
Expand Down
6 changes: 6 additions & 0 deletions ...nceCollector/Perf.Shared.NetStandard/Implementation/QuickPulse/QuickPulseServiceClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ internal sealed class QuickPulseServiceClient : IQuickPulseServiceClient
{
private readonly string instanceName;

private readonly string roleName;

private readonly string streamId;

private readonly string machineName;
Expand Down Expand Up @@ -51,6 +53,7 @@ internal sealed class QuickPulseServiceClient : IQuickPulseServiceClient
public QuickPulseServiceClient(
Uri serviceUri,
string instanceName,
string roleName,
string streamId,
string machineName,
string version,
Expand All @@ -61,6 +64,7 @@ public QuickPulseServiceClient(
{
this.ServiceUri = serviceUri;
this.instanceName = instanceName;
this.roleName = roleName;
this.streamId = streamId;
this.machineName = machineName;
this.version = version;
Expand Down Expand Up @@ -234,6 +238,7 @@ private void WritePingData(DateTimeOffset timestamp, Stream stream)
InvariantVersion = MonitoringDataPoint.CurrentInvariantVersion,
// InstrumentationKey = instrumentationKey, // ikey is currently set in query string parameter
Instance = this.instanceName,
RoleName = this.roleName,
StreamId = this.streamId,
MachineName = this.machineName,
Timestamp = timestamp.UtcDateTime,
Expand Down Expand Up @@ -272,6 +277,7 @@ private void WriteSamples(IEnumerable<QuickPulseDataSample> samples, string inst
InvariantVersion = MonitoringDataPoint.CurrentInvariantVersion,
InstrumentationKey = instrumentationKey,
Instance = this.instanceName,
RoleName = this.roleName,
StreamId = this.streamId,
MachineName = this.machineName,
Timestamp = sample.EndTimestamp.UtcDateTime,
Expand Down
Loading