Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update version of Microsoft.AspNetCore.Hosting to 2.1.0 (and fix major test bug) #2026

Merged
merged 4 commits into from
Sep 4, 2020
Merged

update version of Microsoft.AspNetCore.Hosting to 2.1.0 (and fix major test bug) #2026

merged 4 commits into from
Sep 4, 2020

Conversation

cijothomas
Copy link
Contributor

@cijothomas cijothomas commented Sep 4, 2020 •
edited by TimothyMothra
Loading

Fix Issue #1902 .

Changes

  • Update Microsoft.AspNetCore.Hosting to v2.1.0
  • Fix major test bug; multiple test hosts were being created which affected test outcome. Fix is to migrate to Integration Tests.

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@TimothyMothra TimothyMothra mentioned this pull request Sep 4, 2020
Closed
4 tasks
@TimothyMothra
Copy link
Member

Please update the Changelog.

@TimothyMothra TimothyMothra changed the title Refactor tests and fix several issues in one go update version of Microsoft.AspNetCore.Hosting to 2.1.0 (and fix major test bug) Sep 4, 2020
@TimothyMothra TimothyMothra linked an issue Sep 4, 2020 that may be closed by this pull request
NuGet package has dependency with known security vulnerabilities (Microsoft.AspNetCore.Hosting) #1902
Closed
@TimothyMothra TimothyMothra merged commit c2030e4 into develop Sep 4, 2020
eddynaka added a commit that referenced this pull request Sep 4, 2020
@eddynaka
Updating linux pipeline
c28baf4 
changing to ubuntu-latest (18.04 for now)

reverting

moving to ubuntu-latest

Remove EmptyApp tests as its covered eslewhere (#2025)

* Remove EmptyApp tests as its covered eslewhere

* cleanup

Ingestion service data delivery status (#1887)

* Added eventhandler to transmission

* Updated public API

* Modified changelog.md

* Added more tests

* Fix API

* Added coverage for timeout

* Update to API

* Modified comment in transmission.

* PR Comments

* PR feedback

* Fix test

* Added TransmissionStatusEvent to InMemoryChannel.

* Remove Inmemory change

Co-authored-by: Cijo Thomas <[email protected]>
Co-authored-by: Timothy Mothra <[email protected]>

update version of Microsoft.AspNetCore.Hosting to 2.1.0 (and fix major test bug) (#2026)

* Refactor tests and fix several issues in one go

* remove unwanted changes

* update changelog

Co-authored-by: Timothy Mothra Lee <[email protected]>

changing to posix

updating orderby
eddynaka added a commit that referenced this pull request Sep 4, 2020
@eddynaka
Updating linux pipeline
25d3b04 
changing to ubuntu-latest (18.04 for now)

reverting

moving to ubuntu-latest

Remove EmptyApp tests as its covered eslewhere (#2025)

* Remove EmptyApp tests as its covered eslewhere

* cleanup

Ingestion service data delivery status (#1887)

* Added eventhandler to transmission

* Updated public API

* Modified changelog.md

* Added more tests

* Fix API

* Added coverage for timeout

* Update to API

* Modified comment in transmission.

* PR Comments

* PR feedback

* Fix test

* Added TransmissionStatusEvent to InMemoryChannel.

* Remove Inmemory change

Co-authored-by: Cijo Thomas <[email protected]>
Co-authored-by: Timothy Mothra <[email protected]>

update version of Microsoft.AspNetCore.Hosting to 2.1.0 (and fix major test bug) (#2026)

* Refactor tests and fix several issues in one go

* remove unwanted changes

* update changelog

Co-authored-by: Timothy Mothra Lee <[email protected]>

changing to posix

updating orderby
eddynaka added a commit that referenced this pull request Sep 4, 2020
@eddynaka
Updating linux pipeline
2843513 
changing to ubuntu-latest (18.04 for now)

reverting

moving to ubuntu-latest

Remove EmptyApp tests as its covered eslewhere (#2025)

* Remove EmptyApp tests as its covered eslewhere

* cleanup

Ingestion service data delivery status (#1887)

* Added eventhandler to transmission

* Updated public API

* Modified changelog.md

* Added more tests

* Fix API

* Added coverage for timeout

* Update to API

* Modified comment in transmission.

* PR Comments

* PR feedback

* Fix test

* Added TransmissionStatusEvent to InMemoryChannel.

* Remove Inmemory change

Co-authored-by: Cijo Thomas <[email protected]>
Co-authored-by: Timothy Mothra <[email protected]>

update version of Microsoft.AspNetCore.Hosting to 2.1.0 (and fix major test bug) (#2026)

* Refactor tests and fix several issues in one go

* remove unwanted changes

* update changelog

Co-authored-by: Timothy Mothra Lee <[email protected]>

changing to posix

updating orderby

removing unused usings and space
eddynaka added a commit that referenced this pull request Sep 4, 2020
@eddynaka
Updating linux pipeline
c174e0c 
changing to ubuntu-latest (18.04 for now)

reverting

moving to ubuntu-latest

Remove EmptyApp tests as its covered eslewhere (#2025)

* Remove EmptyApp tests as its covered eslewhere

* cleanup

Ingestion service data delivery status (#1887)

* Added eventhandler to transmission

* Updated public API

* Modified changelog.md

* Added more tests

* Fix API

* Added coverage for timeout

* Update to API

* Modified comment in transmission.

* PR Comments

* PR feedback

* Fix test

* Added TransmissionStatusEvent to InMemoryChannel.

* Remove Inmemory change

Co-authored-by: Cijo Thomas <[email protected]>
Co-authored-by: Timothy Mothra <[email protected]>

update version of Microsoft.AspNetCore.Hosting to 2.1.0 (and fix major test bug) (#2026)

* Refactor tests and fix several issues in one go

* remove unwanted changes

* update changelog

Co-authored-by: Timothy Mothra Lee <[email protected]>

changing to posix

updating orderby

removing unused usings and space

updating trx folder path

udoing
@cijothomas cijothomas deleted the cijothomas/refactortest_major branch September 4, 2020 13:35
cijothomas pushed a commit that referenced this pull request Sep 4, 2020
@eddynaka
Updating linux pipeline (#2022)
cf07c3e 
changing to ubuntu-latest (18.04 for now)

reverting

moving to ubuntu-latest

Remove EmptyApp tests as its covered eslewhere (#2025)

* Remove EmptyApp tests as its covered eslewhere

* cleanup

Ingestion service data delivery status (#1887)

* Added eventhandler to transmission

* Updated public API

* Modified changelog.md

* Added more tests

* Fix API

* Added coverage for timeout

* Update to API

* Modified comment in transmission.

* PR Comments

* PR feedback

* Fix test

* Added TransmissionStatusEvent to InMemoryChannel.

* Remove Inmemory change

Co-authored-by: Cijo Thomas <[email protected]>
Co-authored-by: Timothy Mothra <[email protected]>

update version of Microsoft.AspNetCore.Hosting to 2.1.0 (and fix major test bug) (#2026)

* Refactor tests and fix several issues in one go

* remove unwanted changes

* update changelog

Co-authored-by: Timothy Mothra Lee <[email protected]>

changing to posix

updating orderby

removing unused usings and space

updating trx folder path

udoing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyMothra TimothyMothra TimothyMothra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NuGet package has dependency with known security vulnerabilities (Microsoft.AspNetCore.Hosting)
2 participants
@cijothomas @TimothyMothra