Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to OpenTelemetry 1.28.0 #3199

Merged
merged 4 commits into from
Jul 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ public void customize(AutoConfigurationCustomizer autoConfiguration) {
}

// TODO (trask) add this method to AutoConfigurationCustomizer upstream?
((AutoConfiguredOpenTelemetrySdkBuilder) autoConfiguration).registerShutdownHook(false);
((AutoConfiguredOpenTelemetrySdkBuilder) autoConfiguration).disableShutdownHook();

QuickPulse quickPulse;
if (configuration.preview.liveMetrics.enabled) {
Expand Down Expand Up @@ -648,7 +648,7 @@ private static SdkLoggerProviderBuilder configureLogging(
.setScheduleDelay(getBatchProcessorDelay())
.build();

builder.addLogRecordProcessor(new TimestampingLogRecordProcessor(batchLogProcessor));
builder.addLogRecordProcessor(batchLogProcessor);
}

return builder;
Expand Down

This file was deleted.

2 changes: 1 addition & 1 deletion buildSrc/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ dependencies {

implementation("org.owasp:dependency-check-gradle:8.3.1")

implementation("io.opentelemetry.instrumentation:gradle-plugins:1.27.0-alpha")
implementation("io.opentelemetry.instrumentation:gradle-plugins:1.28.0-alpha")

implementation("net.ltgt.gradle:gradle-errorprone-plugin:3.1.0")
implementation("net.ltgt.gradle:gradle-nullaway-plugin:1.6.0")
Expand Down
6 changes: 3 additions & 3 deletions dependencyManagement/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ data class DependencySet(val group: String, val version: String, val modules: Li
val dependencyVersions = hashMapOf<String, String>()
rootProject.extra["versions"] = dependencyVersions

val otelVersion = "1.27.0"
val otelInstrumentationAlphaVersion = "1.27.0-alpha"
val otelInstrumentationVersion = "1.27.0"
val otelVersion = "1.28.0"
val otelInstrumentationAlphaVersion = "1.28.0-alpha"
val otelInstrumentationVersion = "1.28.0"
val otelContribAlphaVersion = "1.18.0-alpha"

rootProject.extra["otelVersion"] = otelVersion
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ void doMostBasicTest() throws Exception {

Envelope rdEnvelope2 = getRequestEnvelope(rdList, "message process");
Envelope rddEnvelope1 = getDependencyEnvelope(rddList, "HelloController.sendMessage");
Envelope rddEnvelope2 = getDependencyEnvelope(rddList, "message send");
Envelope rddEnvelope2 = getDependencyEnvelope(rddList, "message publish");
Envelope rddEnvelope3 = getDependencyEnvelope(rddList, "GET /");

assertThat(rdEnvelope1.getSampleRate()).isNull();
Expand Down Expand Up @@ -65,7 +65,7 @@ void doMostBasicTest() throws Exception {
assertThat(rdd1.getProperties()).isEmpty();
assertThat(rdd1.getSuccess()).isTrue();

assertThat(rdd2.getName()).isEqualTo("message send");
assertThat(rdd2.getName()).isEqualTo("message publish");
assertThat(rdd2.getData()).isNull();
assertThat(rdd2.getType()).isEqualTo("Queue Message | jms");
assertThat(rdd2.getTarget()).isEqualTo("message");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ void doMostBasicTest() throws Exception {
assertThat(testing.mockedIngestion.getCountForType("EventData")).isZero();

Envelope rdEnvelope2 = getRequestEnvelope(rdList, "message process");
Envelope rddEnvelope1 = getDependencyEnvelope(rddList, "message send");
Envelope rddEnvelope1 = getDependencyEnvelope(rddList, "message publish");
Envelope rddEnvelope2 = getDependencyEnvelope(rddList, "GET /");

assertThat(rdEnvelope1.getSampleRate()).isNull();
Expand All @@ -61,7 +61,7 @@ void doMostBasicTest() throws Exception {
.containsExactly(entry("_MS.ProcessedByMetricExtractors", "True"));
assertThat(rd1.getSuccess()).isTrue();

assertThat(rdd1.getName()).isEqualTo("message send");
assertThat(rdd1.getName()).isEqualTo("message publish");
assertThat(rdd1.getData()).isNull();
assertThat(rdd1.getType()).isEqualTo("Queue Message | jms");
assertThat(rdd1.getTarget()).isEqualTo("message");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ void doMostBasicTest() throws Exception {

Envelope rdEnvelope2 = getRequestEnvelope(rdList, "mytopic process");
Envelope rddEnvelope1 = getDependencyEnvelope(rddList, "HelloController.sendMessage");
Envelope rddEnvelope2 = getDependencyEnvelope(rddList, "mytopic send");
Envelope rddEnvelope2 = getDependencyEnvelope(rddList, "mytopic publish");
Envelope rddEnvelope3 = getDependencyEnvelope(rddList, "GET /");

assertThat(rdEnvelope1.getSampleRate()).isNull();
Expand Down Expand Up @@ -72,7 +72,7 @@ void doMostBasicTest() throws Exception {
assertThat(rdd1.getProperties()).isEmpty();
assertThat(rdd1.getSuccess()).isTrue();

assertThat(rdd2.getName()).isEqualTo("mytopic send");
assertThat(rdd2.getName()).isEqualTo("mytopic publish");
assertThat(rdd2.getData()).isNull();
assertThat(rdd2.getType()).isEqualTo("Queue Message | kafka");
assertThat(rdd2.getTarget()).isEqualTo("mytopic");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ void doMostBasicTest() throws Exception {
}

Envelope rdEnvelope2 = getRequestEnvelope(rdList, "mytopic process");
Envelope rddEnvelope1 = getDependencyEnvelope(rddList, "mytopic send");
Envelope rddEnvelope1 = getDependencyEnvelope(rddList, "mytopic publish");
Envelope rddEnvelope2 = getDependencyEnvelope(rddList, "GET /");

assertThat(rdEnvelope1.getSampleRate()).isNull();
Expand All @@ -78,7 +78,7 @@ void doMostBasicTest() throws Exception {
.containsExactly(entry("_MS.ProcessedByMetricExtractors", "True"));
assertThat(rd1.getSuccess()).isTrue();

assertThat(rdd1.getName()).isEqualTo("mytopic send");
assertThat(rdd1.getName()).isEqualTo("mytopic publish");
assertThat(rdd1.getData()).isNull();
assertThat(rdd1.getType()).isEqualTo("Queue Message | kafka");
assertThat(rdd1.getTarget()).isEqualTo("mytopic");
Expand Down
7 changes: 5 additions & 2 deletions smoke-tests/apps/Logback/src/main/resources/logback.xml
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
<?xml version="1.0" encoding="UTF-8"?>
<configuration debug="true">
<appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
<appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">
<encoder>
<pattern>%d{yyyy-MM-dd HH:mm:ss.SSS} %-5level %logger{36} - %msg%n</pattern>
</encoder>
</appender>

<logger name="smoketestapp">
<level value="trace"/>
</logger>

<root>
<appender-ref ref="STDOUT"/>
<appender-ref ref="CONSOLE"/>
</root>
</configuration>
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ void doMostBasicTest() throws Exception {
assertThat(rdd1.getProperties()).isEmpty();
assertThat(rdd1.getSuccess()).isTrue();

assertThat(rdd2.getName()).isEqualTo("greetings send");
assertThat(rdd2.getName()).isEqualTo("greetings publish");
assertThat(rdd2.getData()).isNull();
assertThat(rdd2.getType()).isEqualTo("Queue Message | kafka");
assertThat(rdd2.getTarget()).isEqualTo("greetings");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ void doMostBasicTest() throws Exception {
.containsExactly(entry("_MS.ProcessedByMetricExtractors", "True"));
assertThat(rd1.getSuccess()).isTrue();

assertThat(rdd1.getName()).isEqualTo("greetings send");
assertThat(rdd1.getName()).isEqualTo("greetings publish");
assertThat(rdd1.getData()).isNull();
assertThat(rdd1.getType()).isEqualTo("Queue Message | kafka");
assertThat(rdd1.getTarget()).isEqualTo("greetings");
Expand Down