Snippet injection Test update #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siyuniu-ms
requested review from
heyams,
jeanbisutti,
ramthi and
trask
as code owners
heyams
reviewed
Jun 16, 2023
| "percentage": 100 | ||
| }, | ||
| "preview": { | ||
| "javaScriptSnippet": |
There was a problem hiding this comment.
should this be "browserSdkLoader", saw your doc update?
There was a problem hiding this comment.
haha, yes, just updated it.
|
can you update the smoke test name to reflect this renaming and be consistent? |
trask
reviewed
Jun 16, 2023
...ng/src/main/java/com/microsoft/applicationinsights/agent/internal/init/SecondEntryPoint.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Jun 16, 2023
...ava/com/microsoft/applicationinsights/agent/internal/configuration/SnippetConfiguration.java
Outdated
Show resolved
Hide resolved
heyams
approved these changes
Jun 16, 2023
…ights/agent/internal/init/SecondEntryPoint.java Co-authored-by: Trask Stalnaker <[email protected]>
…ights/agent/internal/configuration/SnippetConfiguration.java Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.