Fix 2.x SDK interop #3036
Merged
Fix 2.x SDK interop #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyams
reviewed
May 1, 2023
| mv.visitMethodInsn( | ||
| INVOKEVIRTUAL, | ||
| unshadedPrefix + "/TelemetryConfiguration", | ||
| "isTrackingDisabled", |
There was a problem hiding this comment.
I didn't find any tests for isTackingDisabled or isDisabled. How does customers use it? no ikey is only when they disable tracking, correct?
There was a problem hiding this comment.
they don't use it directly, the 2.x TelemetryClient calls isDisabled() is called in several places
jeanbisutti
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while testing locally. Prior to 3.4.0 the 2.x integration didn't require iKey to be configured on the 2.x side (only on the 3.x side). This broke in 3.4.0, and currently the 2.x integration doesn't emit any telemetry if there's no iKey configured on the 2.x side.