Option to export Logback and Log4j 2 markers #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanbisutti
changed the title
jeanbisutti
commented
Sep 21, 2022
...ter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/LogDataMapper.java
Outdated
Show resolved
Hide resolved
| @@ -167,6 +170,10 @@ private static void setExtraAttributes( | |||
| telemetryBuilder.addProperty("LineNumber", String.valueOf(value)); | |||
| return; | |||
| } | |||
| if (OTEL_LOG_MARKER.getKey().equals(key)) { | |||
| telemetryBuilder.addProperty("Marker", String.valueOf(value)); | |||
There was a problem hiding this comment.
Would Marker be a good property name?
| @@ -10,5 +10,8 @@ | |||
| "logging": { | |||
| "level": "warn" | |||
| } | |||
| }, | |||
| "preview": { | |||
| "captureLog4jMarkerAttribute": true | |||
There was a problem hiding this comment.
The feature only works with Log4j 2 (not for Log4j 1). Would captureLog4j2MarkerAttribute be a better property name?
|
Rabase on top of #2596 before merging |
jeanbisutti
changed the title
trask
approved these changes
Oct 17, 2022
…ureLog4jMarkerAttribute => captureLog4jMarker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.