http server 4xx configuration #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
http-server-4xx-configuration
branch
from
6ab5257 to
14c2f2f
Compare
heyams
reviewed
Jan 10, 2022
| @@ -228,6 +228,7 @@ public String toString() { | |||
| // this is needed to unblock customer, but is not the ideal long-term solution | |||
| // https://portal.microsofticm.com/imp/v3/incidents/details/266992200/home | |||
| public boolean disablePropagation; | |||
| public boolean captureHttpServer4xxAsError = true; | |||
There was a problem hiding this comment.
i saw the IcM 282327358 that is asking to treat 4xx response as success not error. rename?
There was a problem hiding this comment.
I think this naming is a bit better from otel perspective, as the default in otel is not to capture server 4xx as error (but also not to capture it as success, there's a third option in otel - UNSET)
There was a problem hiding this comment.
this is the config customer will be using.. if they wants 4xx as success, they will set this flag to false. unset will return true. yeah, it works.
heyams
approved these changes
Jan 10, 2022
|
let's track this via statsbeat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.