Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add thread name to log capture #1790

Merged
merged 3 commits into from
Jul 7, 2021
Merged

Add thread name to log capture #1790

merged 3 commits into from
Jul 7, 2021

Conversation

trask
Copy link
Member

@trask trask commented Jul 3, 2021

Resolves #1699

kryalama
kryalama reviewed Jul 6, 2021
View reviewed changes
...ooling/src/main/java/com/microsoft/applicationinsights/agent/internal/exporter/Exporter.java Outdated
@@ -407,6 +410,9 @@ private static void setLoggerProperties(MonitorDomain data, String level, String
if (loggerName != null) {
TelemetryUtil.getProperties(data).put("LoggerName", loggerName);
}
if (threadName != null) {
TelemetryUtil.getProperties(data).put("ThreadName", loggerName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be threadName

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 👍

@trask trask merged commit 48b7ace into main Jul 7, 2021
@trask trask deleted the trask/add-thread-name-to-log-capture branch July 7, 2021 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kryalama kryalama kryalama approved these changes

@heyams heyams Awaiting requested review from heyams heyams is a code owner

@xiao-lix xiao-lix Awaiting requested review from xiao-lix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capture thread name for instrumented logs.
2 participants
@trask @kryalama