generated from micronaut-projects/micronaut-project-template
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generics validation #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriy-dmytruk
force-pushed
the
generics-validation
branch
from
November 2, 2022 15:35
5707f21
to
d905f42
Compare
andriy-dmytruk
force-pushed
the
generics-validation
branch
3 times, most recently
from
November 7, 2022 16:20
16874f0
to
a464f35
Compare
graemerocher
requested changes
Nov 7, 2022
validation-visitor/src/main/java/io/micronaut/validation/visitor/ValidationVisitor.java
Outdated
Show resolved
Hide resolved
validation/src/main/java/io/micronaut/validation/ValidatingInterceptor.java
Outdated
Show resolved
Hide resolved
validation/src/main/java/io/micronaut/validation/validator/DefaultValidator.java
Show resolved
Hide resolved
validation/src/main/java/io/micronaut/validation/validator/DefaultValidator.java
Outdated
Show resolved
Hide resolved
validation/src/main/java/io/micronaut/validation/validator/DefaultValidator.java
Outdated
Show resolved
Hide resolved
validation/src/main/java/io/micronaut/validation/validator/ReactiveValidator.java
Outdated
Show resolved
Hide resolved
andriy-dmytruk
force-pushed
the
generics-validation
branch
from
November 7, 2022 23:32
e0d9d2f
to
9dfd6ae
Compare
graemerocher
approved these changes
Nov 8, 2022
andriy-dmytruk
force-pushed
the
generics-validation
branch
from
November 21, 2022 19:21
9dfd6ae
to
3902612
Compare
@andriy-dmytruk shall I merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation for generics such as
List<@NotBlank String>
orMap<String, List<@NotBlank String>>
.The
DefaultValidator
was modified to accommodate for the functionality. Refer to changes in tests for examples and details, like path display in this case.Additionally, publisher validation was modified to be performed in form of
Mono<@Valid Pojo>
. Validation for single publishers (likeMono
) was fixed.