Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency org.apache.groovy:groovy-bom to v4.0.19 - autoclosed #321

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 4, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.apache.groovy:groovy-bom (source) 4.0.18 -> 4.0.19 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "after 10pm" in timezone Europe/Prague, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the type: dependency-upgrade Upgrade a dependency label Mar 4, 2024
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sdelamo
Copy link
Contributor

sdelamo commented Mar 7, 2024

@melix @wetted @timyates can we get rid of declaring the groovy version in every repo?

@wetted
Copy link
Contributor

wetted commented Mar 7, 2024

@melix @wetted @timyates can we get rid of declaring the groovy version in every repo?

I'm all for it. Nearly all the modules use it and the versions (at least patch versions) never seem to be in sync. How do we want to do this?

@timyates
Copy link
Contributor

timyates commented Mar 8, 2024

Groovy's a tricky one... It's strongly bound to both micronaut-test (for spock) and micronaut-groovy (obvs)... But to implement it without creating deployment cycles I think it would need to go in micronaut-core 🤔 Unless someone can think of a better place?

@melix
Copy link
Contributor

melix commented Mar 8, 2024

Yes, I agree that it's complicated. The groovy version should be declared in micronaut-groovy, however core depends on groovy. That's the big deal IMO, which makes it hard to break a cycle. So unless we move the groovy version to core (which implies that we cannot upgrade Groovy without upgrading core), I can't think of a clean solution.

@sdelamo sdelamo merged commit 850740c into master Mar 12, 2024
11 checks passed
@sdelamo sdelamo deleted the renovate/groovy-monorepo branch March 12, 2024 09:42
@renovate renovate bot changed the title fix(deps): update dependency org.apache.groovy:groovy-bom to v4.0.19 fix(deps): update dependency org.apache.groovy:groovy-bom to v4.0.19 - autoclosed Mar 12, 2024
@sdelamo
Copy link
Contributor

sdelamo commented Mar 12, 2024

I think we should define groovy and kotlin in core. At the end those versions are key in the framework. They are the supported programming language versions.

grayc-de-bot pushed a commit to inoa-io/inoa-cloud that referenced this pull request Mar 12, 2024
… v4.4.4 (#82)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io.micronaut.validation:micronaut-validation-bom](https://micronaut.io) ([source](https://github.com/micronaut-projects/micronaut-validation)) | import | patch | `4.4.3` -> `4.4.4` |

---

> ⚠ **Warning**
>
> Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>micronaut-projects/micronaut-validation (io.micronaut.validation:micronaut-validation-bom)</summary>

### [`v4.4.4`](https://github.com/micronaut-projects/micronaut-validation/releases/tag/v4.4.4): Micronaut Validation 4.4.4

[Compare Source](micronaut-projects/micronaut-validation@v4.4.3...v4.4.4)

<!-- Release notes generated using configuration in .github/release.yml at master -->

#### What's Changed

##### Dependency updates 🚀

-   fix(deps): update dependency io.micronaut:micronaut-core-bom to v4.3.10 by [@&#8203;renovate](https://github.com/renovate) in micronaut-projects/micronaut-validation#322
-   fix(deps): update dependency org.apache.groovy:groovy-bom to v4.0.19 - autoclosed by [@&#8203;renovate](https://github.com/renovate) in micronaut-projects/micronaut-validation#321
-   fix(deps): update dependency com.google.devtools.ksp:symbol-processing-gradle-plugin to v1.9.23-1.0.19 by [@&#8203;renovate](https://github.com/renovate) in micronaut-projects/micronaut-validation#323
-   fix(deps): update kotlin monorepo to v1.9.23 by [@&#8203;renovate](https://github.com/renovate) in micronaut-projects/micronaut-validation#324

**Full Changelog**: micronaut-projects/micronaut-validation@v4.4.3...v4.4.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzguMSIsInVwZGF0ZWRJblZlciI6IjM3LjIzOC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Reviewed-on: https://git.grayc.io/inoa/cloud/pulls/82
Co-authored-by: Renovate <[email protected]>
Co-committed-by: Renovate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade Upgrade a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants