Fix type argument annotation inheritance #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andriy-dmytruk Maybe need test case, when you have annotations in interface and in implementation controller together |
andriy-dmytruk
force-pushed
the
andriy/type-argument-inheritence-fix
branch
from
15a5ff0 to
5ca9504
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
I would like to investigate the core fix |
|
I'm going to come up with a better API to get overridden methods; otherwise, this will be a major performance hit. |
|
@dstepanov should this PR be moved to draft until we have an API in core? |
|
@sdelamo I put it to draft. I am going to finish it after the Core is released. |
dstepanov
force-pushed
the
andriy/type-argument-inheritence-fix
branch
from
cabdd7f to
d7668db
Compare
|
Looks like the method |
|
@dstepanov any news about this? |
altro3
added a commit
to altro3/micronaut-validation
that referenced
this pull request
Feb 19, 2024
altro3
added a commit
to altro3/micronaut-validation
that referenced
this pull request
Feb 19, 2024
dstepanov
pushed a commit
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt fix for this issue in core: micronaut-projects/micronaut-core#9984.
This seemed to be a very complicated behavior to fix in core, so I attempted fixing it for validation only.
I think this should work as a solution for now, as not many other modules use type parameters and might not require their inheritance.