-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to new Gradle Shadow plugin #2618
base: 4.7.x
Are you sure you want to change the base?
Switch to new Gradle Shadow plugin #2618
Conversation
Previously this plugin was developed by @johnrengelman and published under the ID com.github.johnrengelman.shadow before maintenance was transferred to the GradleUp organization to ensure future development Functionally it's identical, but it doesn't have deprecation warnings like the old one started having
Seems to be failing on a TestContainers/SQLServer issue which I don't believe is of my doing 😉 |
Yes, it started failing for other projects as well. For sql and data we used different image |
Yes, unless there is a way to override (temporary solution) in application-test.yml or via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a reasonable change, however I think we should probably go into the Gradle plugin and make sure we change it there too, at least in tests.
I made an issue in the gradle plugin, but then found this.. I'll leave open? micronaut-projects/micronaut-gradle-plugin#1080 |
I wonder if this should be considered now micronaut-projects/micronaut-gradle-plugin#1081 is merged into the gradle plugin 🤔 |
Still needs a release |
True.... how soon I forget 😉 |
Previously this plugin was developed by johnrengelman and published under the ID com.github.johnrengelman.shadow before maintenance was transferred to the GradleUp organization to ensure future development
Functionally it's identical, but it doesn't have deprecation warnings like the old one started having
https://github.com/GradleUp/shadow
https://plugins.gradle.org/plugin/com.gradleup.shadow
https://gradleup.com/shadow/