Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file: prefix is not working for static jwks configurations #1635

Merged
merged 5 commits into from
Mar 18, 2024

Conversation

jbreton
Copy link
Contributor

@jbreton jbreton commented Mar 13, 2024

Fix for #1634

We found this bug while setting a static Jwks as a workaround of a possible bug regarding a ReadTimeout that could occur when fetching a Jwks from an url.

We are still investigating the cause of the ReadTimeout and haven't opened an issue since it could be caused by our custom JWT validator. Maybe this will ring a bell as it began when we updated to micronaut 4.3.1 and is still occuring in 4.3.4.

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2024

CLA assistant check
All committers have signed the CLA.

@jbreton jbreton changed the title Fix for issue #1634 file: prefix is not working for static jwks configurations Mar 13, 2024
@etremblay
Copy link

Here is the issue for the ReadTimeout #1633

Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Can you add a test?

@sdelamo sdelamo added the type: bug Something isn't working label Mar 14, 2024
@sdelamo sdelamo self-assigned this Mar 14, 2024
@jbreton
Copy link
Contributor Author

jbreton commented Mar 14, 2024

@sdelamo It's my first time working with groovy. I looked at other tests to see what I could do. Those tests are far from perfect but it's better than nothing at all.

Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@sdelamo sdelamo merged commit d83b604 into micronaut-projects:master Mar 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants