Rename bom -> platform
#29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name "bom" was confusing with regards to the old BOM and the new "core" BOM. We will now refer to the BOM which aggregates several Micronaut modules (including core), driving releases, as the "platform BOM". Each module should have its own BOM, included in this project, and this is where the "core BOM" is included.
|
I think the static analysis error comes from the fact the project isn't found in Sonar anymore because of the rename /cc @alvarosanchez |
graemerocher
approved these changes
Nov 23, 2022
sdelamo
approved these changes
Nov 24, 2022
|
The Sonar project is linked to a repo, not to a Gradle module. I still see the project at https://sonarcloud.io/project/overview?id=micronaut-projects_micronaut-bom If it keeps failing after merging this, I can delete and re-import it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name "bom" was confusing with regards to the old BOM and the new "core" BOM. We will now refer to the BOM which aggregates several Micronaut modules (including core), driving releases, as the "platform BOM".
Each module should have its own BOM, included in this project, and this is where the "core BOM" is included.
This will require both updates to the Micronaut Build plugins and Micronaut Gradle plugin.
The repository should also be renamed for clarity.