-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for JetStream #254
Conversation
546b2e3
to
f6c86f6
Compare
SonarCloud Quality Gate failed. |
@grimmjo can you describe what this PR is trying to achieve? Provide as much context links as possible? |
Cool, thanks! 😎 Looks like there's a breaking change in the configuration You can no longer do (as shown in the documentation):
You would need to change this to
So this would need to be a major version release (4.0.0 at the time of writing this) Also, this Optional looks like it may be accessed without a present check (Sonar is reporting it as a bug) micronaut-nats/nats/src/main/java/io/micronaut/nats/jetstream/intercept/JetStreamConsumerAdvice.java Lines 202 to 204 in f6c86f6
Also there's quite a few code smells which will need looking at 🤔 |
Hey @timyates, The next version will be 4.0.0. I've already bumped the version to 4.0.0-SNAPSHOT. |
7c8a9a5
to
ee349f2
Compare
Please retry analysis of this Pull-Request directly on SonarCloud. |
f55c1f9
to
ccaa466
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few coments
nats/src/main/java/io/micronaut/nats/connect/NatsConnectionFactoryConfig.java
Outdated
Show resolved
Hide resolved
nats/src/main/java/io/micronaut/nats/connect/NatsConnectionFactoryConfig.java
Outdated
Show resolved
Hide resolved
nats/src/main/java/io/micronaut/nats/intercept/NatsIntroductionAdvice.java
Outdated
Show resolved
Hide resolved
nats/src/main/java/io/micronaut/nats/jetstream/annotation/JetStreamClient.java
Outdated
Show resolved
Hide resolved
nats/src/main/java/io/micronaut/nats/jetstream/annotation/JetStreamClient.java
Outdated
Show resolved
Hide resolved
nats/src/main/java/io/micronaut/nats/jetstream/bind/NatsAcknowledgement.java
Outdated
Show resolved
Hide resolved
nats/src/main/java/io/micronaut/nats/jetstream/bind/AcknowledgementBinder.java
Show resolved
Hide resolved
SonarCloud Quality Gate failed. |
This PR provides JetStream support for this module.
Jetstream is a built-in distributed persistence system on top of nats-core. It has additional features likes streams, clustering, replay policies, retention policies and limits, key/value stores.
Later they will also provide a object storage.
Some related links:
Todos:
This PR depends on micronaut-projects/micronaut-core#8424